Created attachment 80175 [details] missing 'Cancel' button and duplicate 'Save' button The bibliographic editor (cataloguing/addbiblio.pl) includes a 'Cancel' button in its toolbar at the top. Actually, most pages in Koha which allow you to add/edit something (e.g. MARC Framework, Authority types, Authorised values, etc.) have a 'Cancel' button or link. The authority editor (authorities/authorities.pl), however, does not have a 'Cancel' button. Oddly, it has two 'Save' buttons, as per the attached screenshot. I propose to: a) add a 'Cancel' button to the toolbar at the top of the page b) remove the 'Save' button from the bottom of the page since the floating toolbar already has one.
Created attachment 80176 [details] [review] Bug 21513: Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button The authority editor (authorities/authorities.pl) does not have a 'Cancel' button. Also, it has two 'Save' buttons. This patch fixes that by: a) adding a 'Cancel' button to the floating toolbar at the top b) removing the 'Save' button from the bottom of the page Test plan: 1) Go to Home > Authorities and launch the authority editor by clicking on 'New authority'. Notice how the editor doesn't have a 'Cancel' button. Also notice the two 'Save' buttons. 2) Apply the patch. 3) Re-launch the authority editor, and hit cancel; you should be taken back to Home > Authorities. 4) Edit an existing authority, and hit cancel; you should be taken back to the details page for the authority you chose. 5) Edit an authority as new (duplicate), and hit cancel; you should be taken back to Home > Authorities (this behaviour is mimicking the bibliographic editor: when duplicating a biblio the 'Cancel' button will take you back to Home > Cataloging).
Created attachment 80177 [details] [review] Bug 21513: Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button The authority editor (authorities/authorities.pl) does not have a 'Cancel' button. Also, it has two 'Save' buttons. This patch fixes that by: a) adding a 'Cancel' button to the floating toolbar at the top b) removing the 'Save' button from the bottom of the page Test plan: 1) Go to Home > Authorities and launch the authority editor by clicking on 'New authority'. Notice how the editor doesn't have a 'Cancel' button. Also notice the two 'Save' buttons. 2) Apply the patch. 3) Re-launch the authority editor, and hit cancel; you should be taken back to Home > Authorities. 4) Edit an existing authority, and hit cancel; you should be taken back to the details page for the authority you chose. 5) Edit an authority as new (duplicate), and hit cancel; you should be taken back to Home > Authorities (this behaviour is mimicking the bibliographic editor: when duplicating a biblio the 'Cancel' button will take you back to Home > Cataloging). Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 80254 [details] [review] Bug 21513: Add a 'Cancel' button to the authority editor and remove duplicate 'Save' button The authority editor (authorities/authorities.pl) does not have a 'Cancel' button. Also, it has two 'Save' buttons. This patch fixes that by: a) adding a 'Cancel' button to the floating toolbar at the top b) removing the 'Save' button from the bottom of the page Test plan: 1) Go to Home > Authorities and launch the authority editor by clicking on 'New authority'. Notice how the editor doesn't have a 'Cancel' button. Also notice the two 'Save' buttons. 2) Apply the patch. 3) Re-launch the authority editor, and hit cancel; you should be taken back to Home > Authorities. 4) Edit an existing authority, and hit cancel; you should be taken back to the details page for the authority you chose. 5) Edit an authority as new (duplicate), and hit cancel; you should be taken back to Home > Authorities (this behaviour is mimicking the bibliographic editor: when duplicating a biblio the 'Cancel' button will take you back to Home > Cataloging). Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as expected, no regressions found. Code is good and moves us towards a more unified experience. Passing QA
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.06
Very nice and useful. Pushed to 17.11.x for 17.11.12