Bug 21516 - Request notes CSS bug makes them unreadable
Summary: Request notes CSS bug makes them unreadable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Andrew Isherwood
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 7317
Blocks:
  Show dependency treegraph
 
Reported: 2018-10-08 10:04 UTC by Andrew Isherwood
Modified: 2018-12-12 17:32 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21516: Fix incorrect CSS (1.24 KB, patch)
2018-10-08 10:12 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 21516: (ALTERNATE) Request notes CSS bug makes them unreadable (14.76 KB, patch)
2018-11-13 16:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21516: (ALTERNATE) Request notes CSS bug makes them unreadable (14.83 KB, patch)
2018-11-13 17:01 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 21516: (ALTERNATE) Request notes CSS bug makes them unreadable (14.92 KB, patch)
2018-11-16 07:27 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Isherwood 2018-10-08 10:04:16 UTC
There's a bug in the CSS that is indirectly related to the layout of the staff and OPAC request notes. There's a 1em height specified that cascades to all divs in the containing div, this is fine for everything apart from the notes, which may need a height greater than 1em. An exception rule needs creating.
Comment 1 Andrew Isherwood 2018-10-08 10:12:54 UTC
Created attachment 80209 [details] [review]
Bug 21516: Fix incorrect CSS

Override the height definition for notes fields.

Test plan:

(Before applying the patch)
1. Create an ILL request and modify it to add staff notes and OPAC
notes, each notes field should be quite lengthy.
2. View the request and observe that the notes field lines overlap each
other
3. Apply the patch
4. Observe that the notes fields now display correctly
Comment 2 Andrew Isherwood 2018-10-31 09:16:23 UTC
Test plan:

(Before applying the patch)
1. Create an ILL request and modify it to add staff notes and OPAC
notes, each notes field should be quite lengthy.
2. View the request and observe that the notes field lines overlap each
other
3. Apply the patch
4. Regenerate the CSS (npm run css)
5. Observe that the notes fields now display correctly
Comment 3 Owen Leonard 2018-11-13 16:48:52 UTC
Created attachment 82309 [details] [review]
Bug 21516: (ALTERNATE) Request notes CSS bug makes them unreadable

This alternate patch makes multiple markup corrections to the ILL
requests templates. It reformats the request details to use a list,
making it consistent with similar interfaces (see patron details,
baskets in acquisitions). The display of notes has been changed so that
it uses a paragraph tag instead of <pre>.

To test, apply the patch and rebuild the staff client CSS.

- Manage an ILL request which has staff and OPAC notes. Everything
  should look readable.
- Running validation on the HTML should only return warnings coming from
  global include files (js_includes.inc).
Comment 4 Andrew Isherwood 2018-11-13 17:01:49 UTC
Created attachment 82315 [details] [review]
Bug 21516: (ALTERNATE) Request notes CSS bug makes them unreadable

This alternate patch makes multiple markup corrections to the ILL
requests templates. It reformats the request details to use a list,
making it consistent with similar interfaces (see patron details,
baskets in acquisitions). The display of notes has been changed so that
it uses a paragraph tag instead of <pre>.

To test, apply the patch and rebuild the staff client CSS.

- Manage an ILL request which has staff and OPAC notes. Everything
  should look readable.
- Running validation on the HTML should only return warnings coming from
  global include files (js_includes.inc).

Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Comment 5 Marcel de Rooy 2018-11-16 07:27:01 UTC
Created attachment 82382 [details] [review]
Bug 21516: (ALTERNATE) Request notes CSS bug makes them unreadable

This alternate patch makes multiple markup corrections to the ILL
requests templates. It reformats the request details to use a list,
making it consistent with similar interfaces (see patron details,
baskets in acquisitions). The display of notes has been changed so that
it uses a paragraph tag instead of <pre>.

To test, apply the patch and rebuild the staff client CSS.

- Manage an ILL request which has staff and OPAC notes. Everything
  should look readable.
- Running validation on the HTML should only return warnings coming from
  global include files (js_includes.inc).

Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Marcel de Rooy 2018-11-16 07:27:35 UTC
@RM: rebuild the staff client CSS ?
Comment 7 Nick Clemens 2018-11-16 13:09:28 UTC
Awesome work all!

Pushed to master for 18.11
Comment 8 Jesse Maseto 2018-12-07 17:32:44 UTC
Not able to backport in to 18.05. If this is something that needs to be in 18.05 please provide an 18.05 version.