There's a bug in the CSS that is indirectly related to the layout of the staff and OPAC request notes. There's a 1em height specified that cascades to all divs in the containing div, this is fine for everything apart from the notes, which may need a height greater than 1em. An exception rule needs creating.
Created attachment 80209 [details] [review] Bug 21516: Fix incorrect CSS Override the height definition for notes fields. Test plan: (Before applying the patch) 1. Create an ILL request and modify it to add staff notes and OPAC notes, each notes field should be quite lengthy. 2. View the request and observe that the notes field lines overlap each other 3. Apply the patch 4. Observe that the notes fields now display correctly
Test plan: (Before applying the patch) 1. Create an ILL request and modify it to add staff notes and OPAC notes, each notes field should be quite lengthy. 2. View the request and observe that the notes field lines overlap each other 3. Apply the patch 4. Regenerate the CSS (npm run css) 5. Observe that the notes fields now display correctly
Created attachment 82309 [details] [review] Bug 21516: (ALTERNATE) Request notes CSS bug makes them unreadable This alternate patch makes multiple markup corrections to the ILL requests templates. It reformats the request details to use a list, making it consistent with similar interfaces (see patron details, baskets in acquisitions). The display of notes has been changed so that it uses a paragraph tag instead of <pre>. To test, apply the patch and rebuild the staff client CSS. - Manage an ILL request which has staff and OPAC notes. Everything should look readable. - Running validation on the HTML should only return warnings coming from global include files (js_includes.inc).
Created attachment 82315 [details] [review] Bug 21516: (ALTERNATE) Request notes CSS bug makes them unreadable This alternate patch makes multiple markup corrections to the ILL requests templates. It reformats the request details to use a list, making it consistent with similar interfaces (see patron details, baskets in acquisitions). The display of notes has been changed so that it uses a paragraph tag instead of <pre>. To test, apply the patch and rebuild the staff client CSS. - Manage an ILL request which has staff and OPAC notes. Everything should look readable. - Running validation on the HTML should only return warnings coming from global include files (js_includes.inc). Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Created attachment 82382 [details] [review] Bug 21516: (ALTERNATE) Request notes CSS bug makes them unreadable This alternate patch makes multiple markup corrections to the ILL requests templates. It reformats the request details to use a list, making it consistent with similar interfaces (see patron details, baskets in acquisitions). The display of notes has been changed so that it uses a paragraph tag instead of <pre>. To test, apply the patch and rebuild the staff client CSS. - Manage an ILL request which has staff and OPAC notes. Everything should look readable. - Running validation on the HTML should only return warnings coming from global include files (js_includes.inc). Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
@RM: rebuild the staff client CSS ?
Awesome work all! Pushed to master for 18.11
Not able to backport in to 18.05. If this is something that needs to be in 18.05 please provide an 18.05 version.