Hi, we just ran across the following error when creating a new book order based on a suggestion: > Template process failed: file error - options_for_itemtypes: not found at /usr/share/koha/lib/C4/Templates.pm line 122 Investigating the problem I found a regression in #19289 where a new template processor called "options_for_item_types" got added to intranet-tmpl/prog/en/includes/html_helpers.inc. However, in intranet-tmpl/prog/en/modules/acqui/neworderempty.tt it's called as "options_for_itemtypes". Note the missing underscore in "itemtypes". Cheers
Created attachment 80359 [details] [review] Bug 21537: Fix itemtype processing To test: 0 - Set UseACQFrameworkForBiblioRecords to 'Use' 1 - Define a subfield in the ACQ framework linked to authorised value 'itemtypes' 2 - Make sure that field is visible 3 - Create a purchase suggestion 4 - Accept it 5 - Go to Acquisitions 6 - Find a vendor with an open basket, or create one 7 - Add to the basket using a suggestion 8 - Choose the suggestion 9 - Internal server error 10 - Apply patch 11 - Place order form a suggestion again 12 - Confirm that the field linked to itemtypes shows correctly
Created attachment 80477 [details] [review] Bug 21537: Fix typo for options_for_item_types To test: 0 - Set UseACQFrameworkForBiblioRecords to 'Use' 1 - Define a subfield in the ACQ framework linked to authorised value 'itemtypes' 2 - Make sure that field is visible 3 - Create a purchase suggestion 4 - Accept it 5 - Go to Acquisitions 6 - Find a vendor with an open basket, or create one 7 - Add to the basket using a suggestion 8 - Choose the suggestion 9 - Internal server error 10 - Apply patch 11 - Place order form a suggestion again 12 - Confirm that the field linked to itemtypes shows correctly Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 80504 [details] [review] Bug 21537: Fix typo for options_for_item_types To test: 0 - Set UseACQFrameworkForBiblioRecords to 'Use' 1 - Define a subfield in the ACQ framework linked to authorised value 'itemtypes' 2 - Make sure that field is visible 3 - Create a purchase suggestion 4 - Accept it 5 - Go to Acquisitions 6 - Find a vendor with an open basket, or create one 7 - Add to the basket using a suggestion 8 - Choose the suggestion 9 - Internal server error 10 - Apply patch 11 - Place order form a suggestion again 12 - Confirm that the field linked to itemtypes shows correctly Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Another trivial patch which resolves the problem and causes no regressions. Passing QA
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.05
Depends on Bug 19289 not in 17.11.x