Bug 21541 - HTML filter breaks HTML rendering of SQL output
Summary: HTML filter breaks HTML rendering of SQL output
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on: 13618
Blocks:
  Show dependency treegraph
 
Reported: 2018-10-10 15:48 UTC by Owen Leonard
Modified: 2019-10-14 19:56 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21541: Use raw filter for report results (1.51 KB, patch)
2018-10-10 16:32 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 21541: Use raw filter for report results (1.57 KB, patch)
2018-10-11 21:32 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-10-10 15:48:53 UTC
Many SQL reports use CONCAT to build hyperlinks into reports output. The current version of the template has an html filter on all report output.
Comment 1 Nick Clemens 2018-10-10 16:32:30 UTC
Created attachment 80366 [details] [review]
Bug 21541: Use raw filter for report results

To test:
 1 - Create new report
 SELECT CONCAT('<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=',borrowernumber,'">',"",firstname,"",surname,'</a>')
 AS people
 FROM borrowers
 2 - Run this report
 3 - Note the results contain raw text, they are not hyperlinks
 4 - Apply patch
 5 - Reload the results
 6 - They should now be links
Comment 2 Katrin Fischer 2018-10-11 21:32:48 UTC
Created attachment 80430 [details] [review]
Bug 21541: Use raw filter for report results

To test:
 1 - Create new report
 SELECT CONCAT('<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=',borrowernumber,'">',"",firstname,"",surname,'</a>')
 AS people
 FROM borrowers
 2 - Run this report
 3 - Note the results contain raw text, they are not hyperlinks
 4 - Apply patch
 5 - Reload the results
 6 - They should now be links

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Katrin Fischer 2018-10-11 21:33:16 UTC
One line patch - obviously needed!
Comment 4 Tomás Cohen Arazi 2018-10-13 11:36:32 UTC
Pushed for 18.11. Thanks all!
Comment 5 Martin Renvoize 2018-10-16 12:11:42 UTC
Caused by 13618 not in 18.05.x