When looking through system preferences, you have a menu of all the sysprefs categories on the left. However, if you click on "Local use", the left side menu is the administration menu. To reproduce: 1) Go to Administration > Global system preferences 2) Click on categories on the left-hand side of the screen (for example, "Circulation" or "Staff client", the left-hand side menu stays the same 3) Click on the "Local use" category 4) Notice the left-hand side menu is the administration menu and not the sysprefs categories
Still available on master. See screenshot : https://snipboard.io/CuMvIZ.jpg
Whoever wrote the patch for Bug 20743 was a little too careless with their cut-and-paste and included the wrong menu include. It should be [% INCLUDE 'prefs-menu.inc' %] instead of [% INCLUDE 'admin-menu.inc' %]
Created attachment 95583 [details] [review] Bug 21574 : Local use system preferences page doesn't have the system preferences menu The "local use" tab in system preferences is showing the admin menu instead of the system preferences menu tabs. This patch fixes the menu display. To test: 1) Go to the system preferences in administration. 2) Click the 'Local use' tab. 3) Observe the inncorrect menu. 4) Apply the patch. 5) Repeat steps 1-2 6) Observe the correct menu.
Created attachment 95592 [details] [review] Bug 21574 : Local use system preferences page doesn't have the system preferences menu The "local use" tab in system preferences is showing the admin menu instead of the system preferences menu tabs. This patch fixes the menu display. To test: 1) Go to th Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 95620 [details] [review] Bug 21574 : Local use system preferences page doesn't have the system preferences menu The "local use" tab in system preferences is showing the admin menu instead of the system preferences menu tabs. This patch fixes the menu display. To test: 1) Go to the system preferences in administration. 2) Click the 'Local use' tab. 3) Observe the inncorrect menu. 4) Apply the patch. 5) Repeat steps 1-2 6) Observe the correct menu. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
I hope I did this correctly, I couldn't find Severine's sign-off line in my commit
Created attachment 95747 [details] [review] Bug 21574: Local use system preferences page doesn't have the system preferences menu The "local use" tab in system preferences is showing the admin menu instead of the system preferences menu tabs. This patch fixes the menu display. To test: 1) Go to the system preferences in administration. 2) Click the 'Local use' tab. 3) Observe the inncorrect menu. 4) Apply the patch. 5) Repeat steps 1-2 6) Observe the correct menu. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work! Pushed to master for 19.11.00