The loop generating orders for vendors with auto_orders set fails as only one of the required two parameters is passed to create_edi_order
Created attachment 80662 [details] [review] Add a test for message buyer_ean method
Created attachment 80663 [details] [review] pass the buyer_ean to order routine Call of the subroutine now matchs documentation and passes parameter validation
(In reply to Colin Campbell from comment #2) > Created attachment 80663 [details] [review] [review] > pass the buyer_ean to order routine > > Call of the subroutine now matchs documentation and passes parameter > validation Hi, is there a test plan for this?
Created attachment 93674 [details] [review] Bug 21580 Add test for message buyer_ean method Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Created attachment 93675 [details] [review] Bug 21580 Pass buyer_ean to create_edi_order create_edi_order requires two parameters to be passed but if vendor was set to auto_order the subroutine was called with basketno only resulting in the error 'no basket or ean passed' - pass the buyer_ean as passed in the quotes message Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Created attachment 93943 [details] [review] Bug 21580: Pass buyer_ean to create_edi_order create_edi_order requires two parameters to be passed but if vendor was set to auto_order the subroutine was called with basketno only resulting in the error 'no basket or ean passed' - pass the buyer_ean as passed in the quotes message Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 93944 [details] [review] Bug 21580: Add test for message buyer_ean method Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 93945 [details] [review] Bug 21580: Pass buyer_ean to create_edi_order create_edi_order requires two parameters to be passed but if vendor was set to auto_order the subroutine was called with basketno only resulting in the error 'no basket or ean passed' - pass the buyer_ean as passed in the quotes message Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Passing QA on this as agreed with RM - both parties heavily using EDIFACT have been involved in the QA process. Tests and QA script pass.
Nice work! Pushed to master for 19.11.00