Reproduced in 17.11 and the current master == Severity reasons == This is loss of information which is likely to get unnoticed. == Test plan == 1. have/create a active budget 2. have/create a fund 3. have/create a vendor with minimal info 4. create a basket with minimal info 5. add an order line to the basket Add a user in "To notify on receiving" 6. Modify the order 7. The patrons isn't here. This is the bug 8. Add a user in "To notify on receiving" 9. Save 10. Modify the order 11. The patron is here now
Created attachment 80799 [details] [review] Bug 21587: don't drop patrons to notify in order creation It only worked on modification. == Test plan == 1. have/create a active budget 2. have/create a fund 3. have/create a vendor with minimal info 4. create a basket with minimal info 5. add an order line to the basket Add a user in "To notify on receiving" 6. Modify the order 7. The patrons isn't here. This is the bug 8. Add a user in "To notify on receiving" 9. Save 10. Modify the order 11. The patron is here now 12. Apply this patch 13. Retry step 5 to 11 and patron should be saved on order creation 14. Celebrate! :D
Created attachment 81166 [details] [review] Bug 21587: don't drop patrons to notify in order creation It only worked on modification. == Test plan == 1. have/create a active budget 2. have/create a fund 3. have/create a vendor with minimal info 4. create a basket with minimal info 5. add an order line to the basket Add a user in "To notify on receiving" 6. Modify the order 7. The patrons isn't here. This is the bug 8. Add a user in "To notify on receiving" 9. Save 10. Modify the order 11. The patron is here now 12. Apply this patch 13. Retry step 5 to 11 and patron should be saved on order creation 14. Celebrate! :D Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 81293 [details] [review] Bug 21587: don't drop patrons to notify in order creation It only worked on modification. == Test plan == 1. have/create a active budget 2. have/create a fund 3. have/create a vendor with minimal info 4. create a basket with minimal info 5. add an order line to the basket Add a user in "To notify on receiving" 6. Modify the order 7. The patrons isn't here. This is the bug 8. Add a user in "To notify on receiving" 9. Save 10. Modify the order 11. The patron is here now 12. Apply this patch 13. Retry step 5 to 11 and patron should be saved on order creation 14. Celebrate! :D Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.06
Pushed to 17.11.x for 17.11.12
Still doesn't work in a 17.11.13.000 koha version. If you add a user to notify in a new order, then save the order and after click on modify : there's no user to notify displayed in this order. If you modify the same order to add a user to notify,then save the order and after click on modify : you can see the user who have add to notify
(In reply to Koha Team Lyon 3 from comment #7) > Still doesn't work in a 17.11.13.000 koha version. > If you add a user to notify in a new order, then save the order and after > click on modify : there's no user to notify displayed in this order. > If you modify the same order to add a user to notify,then save the order and > after click on modify : you can see the user who have add to notify Confirm! Works ok for other versions however. The issue comes from a wrong merge conflict: 289 ModOrderUsers( $orderinfo->{ordernumber}, @order_users ); vs 299 ModOrderUsers( $order->ordernumber, @order_users ); Frido: Why did you change this line?
(In reply to Jonathan Druart from comment #8) > (In reply to Koha Team Lyon 3 from comment #7) > > Still doesn't work in a 17.11.13.000 koha version. > > If you add a user to notify in a new order, then save the order and after > > click on modify : there's no user to notify displayed in this order. > > If you modify the same order to add a user to notify,then save the order and > > after click on modify : you can see the user who have add to notify > > Confirm! > Works ok for other versions however. > > The issue comes from a wrong merge conflict: > > 289 ModOrderUsers( $orderinfo->{ordernumber}, @order_users ); > > vs > > 299 ModOrderUsers( $order->ordernumber, @order_users ); > > Frido: Why did you change this line? Ah sorry i thought it was just a move of the 3 lines. The create a followup for 17.11.x
Created attachment 85692 [details] [review] Bug 21587: [17.11.x] correct rebase
Followup pushed to 17.11.x for 17.11.17