Bug 13692 corrected the series link for records using a 490/800 combination When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank)
Created attachment 80750 [details] [review] Bug 21589: Series link formed from 830 field is incorrect Bug 13692 corrected the series link for records using a 490/800 combination When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank) Test Plan: 1) Catalog two or more records with 830 fields 2) Note the series links are broken 3) Apply this patch 4) Reload the record details page 5) The series link should now work
When I apply the patch and refresh the record detail page, the detail disappears the next moment.
koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl is also affected, since bug 13692 also changed it.
Created attachment 82275 [details] Sample records
Created attachment 82654 [details] [review] Bug 21589: (follow-up) Close initial foreach loop
(In reply to Phil Ringnalda from comment #3) > koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl is also > affected, since bug 13692 also changed it. I agree that the OPAC should be addressed by this bug too.
Created attachment 88582 [details] [review] Bug 21589: Series link formed from 830 field is incorrect Bug 13692 corrected the series link for records using a 490/800 combination When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank) Test Plan: 1) Catalog two or more records with 830 fields 2) Note the series links are broken 3) Apply this patch 4) Reload the record details page 5) The series link should now work 6) Repeat for the OPAC
Created attachment 88734 [details] [review] Bug 21589: Series link formed from 830 field is incorrect Bug 13692 corrected the series link for records using a 490/800 combination When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank) Test Plan: 1) Catalog two or more records with 830 fields 2) Note the series links are broken 3) Apply this patch 4) Reload the record details page 5) The series link should now work 6) Repeat for the OPAC Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
QA: Looking here
Created attachment 88849 [details] [review] Bug 21589: Series link formed from 830 field is incorrect Bug 13692 corrected the series link for records using a 490/800 combination When a record has a 490/830 conbination for series, the link is malformed (title is used as author, title is blank) Test Plan: 1) Catalog two or more records with 830 fields 2) Note the series links are broken 3) Apply this patch 4) Reload the record details page 5) The series link should now work 6) Repeat for the OPAC Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05
backported to 18.05.x for 18.05.13