The text of an email sent via the OPAC 'send shelves' menu item reads "Hi, George sent you from our online catalog, the virtual shelf called ..." Per https://wiki.koha-community.org/wiki/Terminology, we should use 'list' instead of 'virtual shelf'. To re-create 1) Choose a public list from the 'lists' menu in the OPAC. 2) Click 'Send list' 3) Log in as necessary 4) Fill in your own email address 5) Click 'send' 6) Check your email, the sent email will contain the text "sent you from our online catalog, the virtual shelf called". This is hard coded in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt
Created attachment 80754 [details] [review] Bug 21174: change virtual shelf to list in send list email. To test 1) Choose a public list from the 'lists' menu in the OPAC. 2) Click 'Send list' 3) Log in as necessary 4) Fill in your own email address 5) Click 'send' 6) Check your email, the sent email will contain the text "sent you from our online catalog, the virtual shelf called". Apply patch, re-test. The email will now contain "sent you from our online catalog, the list called".
Created attachment 80806 [details] [review] Bug 21174: change virtual shelf to list in send list email. To test 1) Choose a public list from the 'lists' menu in the OPAC. 2) Click 'Send list' 3) Log in as necessary 4) Fill in your own email address 5) Click 'send' 6) Check your email, the sent email will contain the text "sent you from our online catalog, the virtual shelf called". Apply patch, re-test. The email will now contain "sent you from our online catalog, the list called". https://bugs.koha-community.org/show_bug.cgi?id=21590 Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 80850 [details] [review] Bug 21590: change virtual shelf to list in send list email. To test 1) Choose a public list from the 'lists' menu in the OPAC. 2) Click 'Send list' 3) Log in as necessary 4) Fill in your own email address 5) Click 'send' 6) Check your email, the sent email will contain the text "sent you from our online catalog, the virtual shelf called". Apply patch, re-test. The email will now contain "sent you from our online catalog, the list called". Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.06
I prefer to avoid string changes in 17.11.x