There are silent failures not apparent to sued when saving matchpints: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'offset' at row 1 [for Statement "INSERT INTO matchpoint_components (matchpoint_id, sequence, tag, subfields, offset, length) VALUES (?, ?, ?, ?, ?, ?)" with ParamValues: 0='42', 1=1, 2="", 3='', 4="", 5=0] at /home/vagrant/kohaclone/C4/Matcher.pm line 348. Additionally -silent failure if you enter letters into the match value sections, we should probably prevent that
Created attachment 80886 [details] [review] Bug 21606: [sql_modes] Fix matching rules insert Fix: Incorrect integer value: '' for column 'offset' Incorrect integer value: '' for column 'score' Test plan: Add/edit matching rules
Created attachment 81860 [details] [review] Bug 21606: [sql_modes] Fix matching rules insert Fix: Incorrect integer value: '' for column 'offset' Incorrect integer value: '' for column 'score' Test plan: Add/edit matching rules Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Trivial fix, combined SO + QA
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.06
SQL modes not in 17.11.x