This line doesn't seem to work: open( $OUT, '>', "&STDOUT" ) || die("Couldn't duplicate STDOUT: $!"); To recreate: 1 - Enable the TalkingTechItivaPhoneNotification 2 - Copy 'HOLD' notice 'email' transport to the phone section 3 - Enable EnhancedMessagingPreferences 4 - Find a patron and enable 'phone' for the 'Hold filled' notice Note: You might not be able to do this straightaway, bug 21639 If the phone box has a '-' and not a checkbox: sudo koha-mysql kohadev INSERT INTO message_transports (message_attribute_id,message_transport_type,is_digest,letter_module,letter_code) VALUES (4,'phone',0,'reserves','HOLD'); 5 - Place a hold for the patron 6 - Check it in and confirm the hold to set it waiting 7 - sudo koha-shell kohadev 8 - perl misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl --type=RESERVE -w 0 -v 9 - Note the Output says it will be on STDOUT, but nothing is output
Created attachment 81043 [details] [review] Bug 21640: Enable output to STDOUT for Itiva outbound script To test: 1 - Enable the TalkingTechItivaPhoneNotification 2 - Copy 'HOLD' notice 'email' transport to the phone section 3 - Enable EnhancedMessagingPreferences 4 - Find a patron and enable 'phone' for the 'Hold filled' notice Note: You might not be able to do this straightaway, bug 21639 If the phone box has a '-' and not a checkbox: sudo koha-mysql kohadev INSERT INTO message_transports (message_attribute_id,message_transport_type,is_digest,letter_module,letter_code) VALUES (4,'phone',0,'reserves','HOLD'); 5 - Place a hold for the patron 6 - Check it in and confirm the hold to set it waiting 7 - sudo koha-shell kohadev 8 - perl misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl --type=RESERVE -w 0 -v 9 - Note the Output says it will be on STDOUT, but nothing is output 10 - Apply patch 11 - repeat 12 - Hold info is output to command line
Created attachment 81103 [details] [review] Bug 21640: Enable output to STDOUT for Itiva outbound script To test: 1 - Enable the TalkingTechItivaPhoneNotification 2 - Copy 'HOLD' notice 'email' transport to the phone section 3 - Enable EnhancedMessagingPreferences 4 - Find a patron and enable 'phone' for the 'Hold filled' notice Note: You might not be able to do this straightaway, bug 21639 If the phone box has a '-' and not a checkbox: sudo koha-mysql kohadev INSERT INTO message_transports (message_attribute_id,message_transport_type,is_digest,letter_module,letter_code) VALUES (4,'phone',0,'reserves','HOLD'); 5 - Place a hold for the patron 6 - Check it in and confirm the hold to set it waiting 7 - sudo koha-shell kohadev 8 - perl misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl --type=RESERVE -w 0 -v 9 - Note the Output says it will be on STDOUT, but nothing is output 10 - Apply patch 11 - repeat 12 - Hold info is output to command line Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 81867 [details] [review] Bug 21640: Enable output to STDOUT for Itiva outbound script To test: 1 - Enable the TalkingTechItivaPhoneNotification 2 - Copy 'HOLD' notice 'email' transport to the phone section 3 - Enable EnhancedMessagingPreferences 4 - Find a patron and enable 'phone' for the 'Hold filled' notice Note: You might not be able to do this straightaway, bug 21639 If the phone box has a '-' and not a checkbox: sudo koha-mysql kohadev INSERT INTO message_transports (message_attribute_id,message_transport_type,is_digest,letter_module,letter_code) VALUES (4,'phone',0,'reserves','HOLD'); 5 - Place a hold for the patron 6 - Check it in and confirm the hold to set it waiting 7 - sudo koha-shell kohadev 8 - perl misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl --type=RESERVE -w 0 -v 9 - Note the Output says it will be on STDOUT, but nothing is output 10 - Apply patch 11 - repeat 12 - Hold info is output to command line Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Symbol table aliasing (not duplicating) STDOUT is not really nice. (We could just print to STDOUT and optionally select a file handle.) No big deal. Removed the parentheses from die on the same line.
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.06
Pushed to 17.11.x for 17.11.13