The library groups template has several issues which need to be cleaned up: - Bootstrap grid - JavaScript to the footer - Markup corrections
Created attachment 81069 [details] [review] Bug 21645: Clean up library groups template This patch modifies the library groups administration page to help compliance with several coding guidelines: - Move JavaScript to the footer - Convert to Bootstrap grid - Other markup corrections To test, apply the patch and go to Administration -> Library groups. - Confirm that the page how has a "Library groups" heading. - Confirm that action buttons in the table of library groups are styled correctly. - Test both adding and editing groups. The "Required" label on required fields should be styled correctly. - Test all JavaScript-driven interactions on the page: - Adding, editing, and deleting groups - Removing libraries from groups - Expanding and collapsing group hierarchies - Validate the page's HTML and confirm that there are no errors found in the main body of the page.
edit-group classes are twice in some tags delete-group classes are twice in some tags <span>? -- probably should be a closed span. -- the type stuff is in an include file. recheck the div match ups, particularly across include files.
Created attachment 81078 [details] [review] Bug 21645: Clean up library groups template This patch modifies the library groups administration page to help compliance with several coding guidelines: - Move JavaScript to the footer - Convert to Bootstrap grid - Other markup corrections To test, apply the patch and go to Administration -> Library groups. - Confirm that the page how has a "Library groups" heading. - Confirm that action buttons in the table of library groups are styled correctly. - Test both adding and editing groups. The "Required" label on required fields should be styled correctly. - Test all JavaScript-driven interactions on the page: - Adding, editing, and deleting groups - Removing libraries from groups - Expanding and collapsing group hierarchies - Validate the page's HTML and confirm that there are no errors found in the main body of the page.
Header looks better in the case of having library groups, but looks out of place when there are none. Perhaps a pretty shaded box telling us how lonely it is with no library groups would be better, but this isn't a blocker for me. The HTML clean up is awesome (96 -> 5 errors, of which the remainder are include files and have nothing to do with this page specifically).
Created attachment 81081 [details] [review] Bug 21645: Clean up library groups template This patch modifies the library groups administration page to help compliance with several coding guidelines: - Move JavaScript to the footer - Convert to Bootstrap grid - Other markup corrections To test, apply the patch and go to Administration -> Library groups. - Confirm that the page how has a "Library groups" heading. - Confirm that action buttons in the table of library groups are styled correctly. - Test both adding and editing groups. The "Required" label on required fields should be styled correctly. - Test all JavaScript-driven interactions on the page: - Adding, editing, and deleting groups - Removing libraries from groups - Expanding and collapsing group hierarchies - Validate the page's HTML and confirm that there are no errors found in the main body of the page. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 81197 [details] [review] Bug 21645: Clean up library groups template This patch modifies the library groups administration page to help compliance with several coding guidelines: - Move JavaScript to the footer - Convert to Bootstrap grid - Other markup corrections To test, apply the patch and go to Administration -> Library groups. - Confirm that the page how has a "Library groups" heading. - Confirm that action buttons in the table of library groups are styled correctly. - Test both adding and editing groups. The "Required" label on required fields should be styled correctly. - Test all JavaScript-driven interactions on the page: - Adding, editing, and deleting groups - Removing libraries from groups - Expanding and collapsing group hierarchies - Validate the page's HTML and confirm that there are no errors found in the main body of the page. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 81198 [details] [review] Bug 21645: e.preventDefault on click Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 81199 [details] [review] Bug 21645: Fix focus when modal is shown First the event must be defined in the document.ready block, then, since bootstrap 3 the event is 'shown.bs.modal', not 'shown' Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
Enhancement, will not be backported to 18.05.x series.