The overdrive administration template has several issues which need to be cleaned up: - Bootstrap grid - Markup corrections
Created attachment 81079 [details] [review] Bug 21646: Clean up Overdrive template This patch modifies the OverDrive administration page to correct some markup issues: - Switch to Bootstrap grid - Add missing header search box - Add missing DataTable configuration - Remove unnecessary fieldset
Created attachment 86976 [details] [review] Bug 21646: Clean up Overdrive template This patch modifies the OverDrive administration page to correct some markup issues: - Switch to Bootstrap grid - Add missing header search box - Add missing DataTable configuration - Remove unnecessary fieldset To test you do not need to have OverDrive credentials. Apply the patch and go to System preferences -> Enhanced content -> OverDrive. In the description of the "OverDriveAuthName" preference, follow the link to manage "individual branch authnames." - Confirm that the page looks correct, including the header search box, page title, and breadcrumbs - Confirm that the page adjusts well to various browser window sizes. - Confirm that the DataTable works correctly.
Created attachment 86982 [details] [review] Bug 21646: Clean up Overdrive template This patch modifies the OverDrive administration page to correct some markup issues: - Switch to Bootstrap grid - Add missing header search box - Add missing DataTable configuration - Remove unnecessary fieldset To test you do not need to have OverDrive credentials. Apply the patch and go to System preferences -> Enhanced content -> OverDrive. In the description of the "OverDriveAuthName" preference, follow the link to manage "individual branch authnames." - Confirm that the page looks correct, including the header search box, page title, and breadcrumbs - Confirm that the page adjusts well to various browser window sizes. - Confirm that the DataTable works correctly. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
OverDrive library authnames : Not the most appealing form title, I guess?
Created attachment 87175 [details] [review] Bug 21646: Clean up Overdrive template This patch modifies the OverDrive administration page to correct some markup issues: - Switch to Bootstrap grid - Add missing header search box - Add missing DataTable configuration - Remove unnecessary fieldset To test you do not need to have OverDrive credentials. Apply the patch and go to System preferences -> Enhanced content -> OverDrive. In the description of the "OverDriveAuthName" preference, follow the link to manage "individual branch authnames." - Confirm that the page looks correct, including the header search box, page title, and breadcrumbs - Confirm that the page adjusts well to various browser window sizes. - Confirm that the DataTable works correctly. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Awesome work all! Pushed to master for 19.05
Enhancement, will not be backported to 18.11.x series.