Bug 21647 - Clean up SRU fields mapping templates
Summary: Clean up SRU fields mapping templates
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 19436
Blocks: 20654
  Show dependency treegraph
 
Reported: 2018-10-24 15:03 UTC by Owen Leonard
Modified: 2019-10-14 19:58 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21647: Clean up SRU fields mapping templates (8.85 KB, patch)
2018-10-24 15:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21647: Clean up SRU fields mapping templates (8.95 KB, patch)
2018-10-25 11:50 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21647: Clean up SRU fields mapping templates (9.00 KB, patch)
2018-10-26 21:06 UTC, Charles Farmer
Details | Diff | Splinter Review
Bug 21647: Clean up SRU fields mapping templates (9.07 KB, patch)
2018-10-27 20:23 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-10-24 15:03:55 UTC
The SRU fields mapping administration templates have several issues which need to be cleaned up:

- Bootstrap grid
- JavaScript to the footer
- Markup corrections
Comment 1 Owen Leonard 2018-10-24 15:45:08 UTC
Created attachment 81076 [details] [review]
Bug 21647: Clean up SRU fields mapping templates

This patch makes corrections to the SRU field mapping templates
(bibliographic and authority):

 - Bootstrap grid
 - JavaScript to the footer
 - Other markup corrections

To test, apply the patch and go to Administration -> Z39.50/SRU servers

- Add or edit an SRU server
  - Click "Modify" next to the SRU search fields mapping field.
    - Confirm that the popup window layout is correct.
    - Confirm that adding information to the form is correctly saved to
      the SRU server form.
    - Test this process with SRU server record type set to both
      "Authority" and "Bibliographic."
Comment 2 Mark Tompsett 2018-10-25 01:00:08 UTC
For authorities, these unexplained errors happen in validation.

Error: End tag div seen, but there were open elements.
From line 122, column 5; to line 122, column 10
form>↩    </div>↩↩↩↩↩↩
Error: Unclosed element main.
From line 62, column 5; to line 62, column 10
id">↩↩    <main>↩     
Error: Stray end tag div.
From line 129, column 9; to line 129, column 14
↩↩        </div>↩↩
Comment 3 Owen Leonard 2018-10-25 11:50:53 UTC
Created attachment 81132 [details] [review]
Bug 21647: Clean up SRU fields mapping templates

This patch makes corrections to the SRU field mapping templates
(bibliographic and authority):

 - Bootstrap grid
 - JavaScript to the footer
 - Other markup corrections

To test, apply the patch and go to Administration -> Z39.50/SRU servers

- Add or edit an SRU server
  - Click "Modify" next to the SRU search fields mapping field.
    - Confirm that the popup window layout is correct.
    - Confirm that adding information to the form is correctly saved to
      the SRU server form.
    - Test this process with SRU server record type set to both
      "Authority" and "Bibliographic."
Comment 4 Charles Farmer 2018-10-26 21:06:24 UTC
Created attachment 81341 [details] [review]
Bug 21647: Clean up SRU fields mapping templates

This patch makes corrections to the SRU field mapping templates
(bibliographic and authority):

 - Bootstrap grid
 - JavaScript to the footer
 - Other markup corrections

To test, apply the patch and go to Administration -> Z39.50/SRU servers

- Add or edit an SRU server
  - Click "Modify" next to the SRU search fields mapping field.
    - Confirm that the popup window layout is correct.
    - Confirm that adding information to the form is correctly saved to
      the SRU server form.
    - Test this process with SRU server record type set to both
      "Authority" and "Bibliographic."

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Comment 5 Katrin Fischer 2018-10-27 20:23:48 UTC
Created attachment 81365 [details] [review]
Bug 21647: Clean up SRU fields mapping templates

This patch makes corrections to the SRU field mapping templates
(bibliographic and authority):

 - Bootstrap grid
 - JavaScript to the footer
 - Other markup corrections

To test, apply the patch and go to Administration -> Z39.50/SRU servers

- Add or edit an SRU server
  - Click "Modify" next to the SRU search fields mapping field.
    - Confirm that the popup window layout is correct.
    - Confirm that adding information to the form is correctly saved to
      the SRU server form.
    - Test this process with SRU server record type set to both
      "Authority" and "Bibliographic."

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Nick Clemens 2018-11-06 17:56:14 UTC
Awesome work all!

Pushed to master for 18.11
Comment 7 Martin Renvoize 2018-11-16 12:37:12 UTC
Enhancement, will not be backported to 18.05.x series.