The 3 following files must be mandatory and insert during the install process: - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They insert data for - message_transport_types - message_attributes - message_transport_type Otherwise the notice templates (table letter) will fail. Moreover these 3 files are identical and are put in several places (1 per language) to make the description translatable (using the related .txt file) I would suggest to move the 3 .sql files to installer/data/mysql/mandatory, remove all the others (as well as the .txt files) and insert them without asking during the install process.
Created attachment 81088 [details] [review] Bug 21651: Remove language specific sql file for notice templates related tables This patch removes the 3 following files for the different languages - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They were all identical, only one version is kept in installer/data/mysql/mandatory .txt files are removed as well They inserted data for - message_transport_types - message_attributes - message_transport_type
Created attachment 81089 [details] [review] Bug 21651: Always insert notice templates related tables The 3 following files must be mandatory and insert during the install process: - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They insert data for - message_transport_types - message_attributes - message_transport_type Otherwise the notice templates (table letter) will fail. Moreover these 3 files are identical and are put in several places (1 per language) to make the description translatable (using the related .txt file) Test plan: - Install Koha in English and in another language - Select all the sample data => They all should be inserted correctly Note that you cannot select/unselect the checkbox for these 3 tables
Created attachment 81174 [details] [review] Bug 21651: Remove language specific sql file for notice templates related tables This patch removes the 3 following files for the different languages - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They were all identical, only one version is kept in installer/data/mysql/mandatory .txt files are removed as well They inserted data for - message_transport_types - message_attributes - message_transport_type
Created attachment 81175 [details] [review] Bug 21651: Always insert notice templates related tables The 3 following files must be mandatory and insert during the install process: - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They insert data for - message_transport_types - message_attributes - message_transport_type Otherwise the notice templates (table letter) will fail. Moreover these 3 files are identical and are put in several places (1 per language) to make the description translatable (using the related .txt file) Test plan: - Install Koha in English and in another language - Select all the sample data => They all should be inserted correctly Note that you cannot select/unselect the checkbox for these 3 tables
Hi Jonathan, Seems ok except for the "cannot select/unselect the checkbox for these 3 tables" - I was still able to uncheck them? Cheers, Liz
Hum yes, indeed. I have no idea why I added that to the commit message. Do you think we should disable the checkboxes? If we do, we certainly we want to disable all the mandatory ones.
This was a thing I wanted Alex to do along with the onboarder, but translation problems hung it up. Usability wise YES 100% we should not allow mandatory ones to be unticked. But you (or somebody) can do that on another bug if you like. :) I'll test it again, with that not in the test plan and update the commit message if it looks ok. Liz
Created attachment 89196 [details] Screenshot of error trace Hi Jonathan, When testing this and installing all Optional data in English, I got to the end of the onboarding with no issues and then logged in which led me straight into an error trace. The issue was with DateUtils, it looked like it was an issue with the sample news items. I took a screenshot of the Error trace which I'm attaching. This didn't happen when I tried the same process on master.
Created attachment 89318 [details] [review] Bug 21651: Always insert notice templates related tables The 3 following files must be mandatory and insert during the install process: - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They insert data for - message_transport_types - message_attributes - message_transport_type Otherwise the notice templates (table letter) will fail. Moreover these 3 files are identical and are put in several places (1 per language) to make the description translatable (using the related .txt file) Test plan: - Install Koha in English and in another language - Select all the sample data => They all should be inserted correctly Note that you cannot select/unselect the checkbox for these 3 tables
Created attachment 89319 [details] [review] Bug 21651: Always insert notice templates related tables The 3 following files must be mandatory and insert during the install process: - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They insert data for - message_transport_types - message_attributes - message_transport_type Otherwise the notice templates (table letter) will fail. Moreover these 3 files are identical and are put in several places (1 per language) to make the description translatable (using the related .txt file) Test plan: - Install Koha in English and in another language - Select all the sample data => They all should be inserted correctly
I am terribly sorry, Hayley, the path to sysprefs.sql was wrong! It's now fixed.
(In reply to Liz Rea from comment #7) > This was a thing I wanted Alex to do along with the onboarder, but > translation problems hung it up. Usability wise YES 100% we should not allow > mandatory ones to be unticked. > > But you (or somebody) can do that on another bug if you like. :) Thanks for the answer, Liz. I have opened bug 22840.
Created attachment 89367 [details] [review] Bug 21651: Always insert notice templates related tables The 3 following files must be mandatory and insert during the install process: - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They insert data for - message_transport_types - message_attributes - message_transport_type Otherwise the notice templates (table letter) will fail. Moreover these 3 files are identical and are put in several places (1 per language) to make the description translatable (using the related .txt file) Test plan: - Install Koha in English and in another language - Select all the sample data => They all should be inserted correctly Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Created attachment 89599 [details] [review] Bug 21651: Remove language specific sql file for notice templates related tables This patch removes the 3 following files for the different languages - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They were all identical, only one version is kept in installer/data/mysql/mandatory .txt files are removed as well They inserted data for - message_transport_types - message_attributes - message_transport_type Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 89600 [details] [review] Bug 21651: Always insert notice templates related tables The 3 following files must be mandatory and insert during the install process: - message_transport_types.sql - sample_notices_message_attributes.sql - sample_notices_message_transports.sql They insert data for - message_transport_types - message_attributes - message_transport_type Otherwise the notice templates (table letter) will fail. Moreover these 3 files are identical and are put in several places (1 per language) to make the description translatable (using the related .txt file) Test plan: - Install Koha in English and in another language - Select all the sample data => They all should be inserted correctly Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 89601 [details] [review] Bug 21651: (QA follow-up) Remove remaining obsolete file from German web installer Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.06
I'm declining this one for 18.05 because hopefully new Koha users won't be clean installing, and I don't want to take the backport risk. Cheers, Liz