To test: - Find or create a hold with a waitingdate other than today - Check the item in to generate a new hold alert - Select "Confirm and Print" - Verify that the waiting date has changed to the current date The waiting date does not change if you select "Confirm" rather than "Confirm and Print." This causes confusion as it puts the waiting date out of sync with the expiration date. In fact, if ExpireReservesMaxPickUpDelay is off and expired holds must be cancelled manually, a new hold slip can be printed after the cancellation date, causing the hold to show a waiting date after its expiration date.
Hi Andrew, can you confirm this is still an issue in newer versions? 17.11 is on longer maintained.
Confirmed this issue still exists in 19.05. Thanks!
PCCLD is seeing this bug too in 19.05.
We have a customer experiencing the same issue on 18.11.04.
confirmed that this issue still exists in master
Created attachment 129099 [details] [review] Bug 21652: Only set waitingdate to today if there is no waitingdate already 1- Find or create a hold with a waitingdate other than today 2- Check the item in to generate a new hold alert 3- Select "Confirm and Print" 4- Verify that the waiting date has changed to the current date 5- Apply patch 6- Try 1-3 again, if a waitingdate already exists it should not change 7. Try an item with no waitingdate, it should properly update to today
Created attachment 129100 [details] [review] Bug 21652: Only set waitingdate to today if there is no waitingdate already 1- Find or create a hold with a waitingdate other than today 2- Check the item in to generate a new hold alert 3- Select "Confirm and Print" 4- Verify that the waiting date has changed to the current date 5- Apply patch 6- Try 1-3 again, if a waitingdate already exists it should not change 7. Try an item with no waitingdate, it should properly update to today Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Unit tests are missing. Note that you could simply have a 1 line patch with: waitingdate => $self->waitingdate || $today->ymd,
Created attachment 129484 [details] [review] Bug 21652: Unit test
Created attachment 129485 [details] [review] Bug 21652: Only set waitingdate to today if there is no waitingdate already 1- Find or create a hold with a waitingdate other than today 2- Check the item in to generate a new hold alert 3- Select "Confirm and Print" 4- Verify that the waiting date has changed to the current date 5- Apply patch 6- Try 1-3 again, if a waitingdate already exists it should not change 7. Try an item with no waitingdate, it should properly update to today Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 129635 [details] [review] Bug 21652: Unit test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 129636 [details] [review] Bug 21652: Only set waitingdate to today if there is no waitingdate already 1- Find or create a hold with a waitingdate other than today 2- Check the item in to generate a new hold alert 3- Select "Confirm and Print" 4- Verify that the waiting date has changed to the current date 5- Apply patch 6- Try 1-3 again, if a waitingdate already exists it should not change 7. Try an item with no waitingdate, it should properly update to today Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 129637 [details] [review] Bug 21652: Simplify code And add a test. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.03
Pushed to 21.05.x for 21.05.11
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.