Bug 21691 - Koha::Account->non_issues_charges has no tests
Summary: Koha::Account->non_issues_charges has no tests
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jasmine Amohia
QA Contact: Tomás Cohen Arazi
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2018-10-26 15:40 UTC by Martin Renvoize
Modified: 2020-01-06 20:14 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21691: Created test for Koha::Account->non_issues_charges (1.28 KB, patch)
2019-01-17 04:06 UTC, Jasmine Amohia
Details | Diff | Splinter Review
Bug 21691: Created test for Koha::Account->non_issues_charges (1.33 KB, patch)
2019-01-17 09:28 UTC, Devinim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2018-10-26 15:40:02 UTC
Everything in the Koha namespace should be properly tested.. but Koha::Account has a number of methods that are missing corresponding tests.
Comment 1 Aleisha Amohia 2019-01-16 22:42:24 UTC
These tests will go in t/db_dependent/Koha/Account.t
This page may help: https://wiki.koha-community.org/wiki/Unit_Tests
Comment 2 Jasmine Amohia 2019-01-17 04:06:20 UTC
Created attachment 84123 [details] [review]
Bug 21691:  Created test for Koha::Account->non_issues_charges

Test Plan:
1) Run test for t/db_dependent/Koha/Account.t and confirm that all tests are successful
Comment 3 Devinim 2019-01-17 09:28:52 UTC
Created attachment 84135 [details] [review]
Bug 21691: Created test for Koha::Account->non_issues_charges

Test Plan:
1) Run test for t/db_dependent/Koha/Account.t and confirm that all tests are successful

Signed-off-by: Devinim <kohadevinim@devinim.com.tr>
Comment 4 Tomás Cohen Arazi 2019-02-18 14:17:52 UTC
Hi, I've jut spotted that t/db_dependent/Accounts.t has a broad coverage of this method. Unfortunately it wasn't on the place we would've expected (t/db_dependent/Koha/Account.t).