Bug 21711 - Remove $shib in Auth.t (17776 folllow-up)
Summary: Remove $shib in Auth.t (17776 folllow-up)
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Authentication (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on: 17776
Blocks:
  Show dependency treegraph
 
Reported: 2018-10-29 12:43 UTC by Marcel de Rooy
Modified: 2019-10-14 19:58 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21711: Remove $shib in Auth.t (17776 folllow-up) (1.12 KB, patch)
2018-10-29 12:44 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2018-10-29 12:43:03 UTC
See patch (QA follow-up) Remove shibboleth package variables on bug 17776.
The variable is no longer global and should be removed in Auth.t.
Trivial.
Comment 1 Marcel de Rooy 2018-10-29 12:44:53 UTC
Created attachment 81484 [details] [review]
Bug 21711: Remove $shib in Auth.t (17776 folllow-up)

See patch (QA follow-up) Remove shibboleth package variables on bug 17776.
The variable is no longer global and should be removed in Auth.t.
Trivial.

Resolves warning:
Name "C4::Auth::shib" used only once: possible typo at t/db_dependent/Auth.t line 298.

Test plan:
Run t/db_dependent/Auth.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2018-10-29 12:45:53 UTC
Moving into PQA directly (could be considered as a trivial QA follow-up for 17776).
Comment 3 Marcel de Rooy 2018-10-29 12:48:16 UTC
No more results from git grep -E "::shib" btw after this.
Comment 4 Nick Clemens 2018-11-07 21:57:50 UTC
I don't get any instances in grep before this patch?
Comment 5 Marcel de Rooy 2018-11-08 07:51:46 UTC
(In reply to Nick Clemens from comment #4)
> I don't get any instances in grep before this patch?

Ah. This is foolish. It came from a patch set that is not pushed yet..