Both are now on separate files and descriptions are not enclosed by <span> tags, making it more error prone on the translation step.
Created attachment 81519 [details] [review] Bug 21715: Ease translation of account and account offset type descriptions This patch moves accounts-related descriptions into a single file to ease finding them, and also encloses descriptions inside <span> tags to make it easier to translate. To test: - Apply this patch - Verify the templates work as expected => SUCCESS: No behaviour change - Sign off :-D Bonus: there were two cases in which the INCLUDE line used 'accountline' as parameter, making it fail to pick the right account type!
Created attachment 81524 [details] [review] Bug 21715: Ease translation of account and account offset type descriptions This patch moves accounts-related descriptions into a single file to ease finding them, and also encloses descriptions inside <span> tags to make it easier to translate. To test: - Apply this patch - Verify the templates work as expected => SUCCESS: No behaviour change - Sign off :-D Bonus: there were two cases in which the INCLUDE line used 'accountline' as parameter, making it fail to pick the right account type!
Created attachment 81544 [details] [review] Bug 21715: Ease translation of account and account offset type descriptions This patch moves accounts-related descriptions into a single file to ease finding them, and also encloses descriptions inside <span> tags to make it easier to translate. To test: - Apply this patch - Verify the templates work as expected => SUCCESS: No behaviour change - Sign off :-D Bonus: there were two cases in which the INCLUDE line used 'accountline' as parameter, making it fail to pick the right account type! Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
btw, we should get rigt of the "thanks" :)
Created attachment 81651 [details] [review] Bug 21715: Ease translation of account and account offset type descriptions This patch moves accounts-related descriptions into a single file to ease finding them, and also encloses descriptions inside <span> tags to make it easier to translate. To test: - Apply this patch - Verify the templates work as expected => SUCCESS: No behaviour change - Sign off :-D Bonus: there were two cases in which the INCLUDE line used 'accountline' as parameter, making it fail to pick the right account type! Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I guess you could argue which is easier. At the moment it's easy to make a typo, but you have all strings together in one entry which gives you context. With this patch they will all appear separately and out of order.
What I wanted to say too: But it follows an existing pattern and will be less error-prone.
Awesome work all! Pushed to master for 18.11
Causation not in 18.05.x series.