All account handling should go via the Koha::Account class.
Created attachment 83257 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`.
Created attachment 83258 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`.
Created attachment 83259 [details] [review] Bug 21756: Replace manualinvoice with add_debit in tests
Created attachment 83260 [details] [review] Bug 21747: Update members/manivoice to use add_debit
Created attachment 83261 [details] [review] Bug 21747: Add deprecation warning to manualinvoice
Created attachment 83262 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`.
Created attachment 83263 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`.
Created attachment 83264 [details] [review] Bug 21756: Replace manualinvoice with add_debit in tests
Created attachment 83265 [details] [review] Bug 21747: Update members/manivoice to use add_debit
Created attachment 83266 [details] [review] Bug 21747: Add deprecation warning to manualinvoice
Created attachment 83267 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`.
Created attachment 83268 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`.
Created attachment 83269 [details] [review] Bug 21756: Replace manualinvoice with add_debit in tests
Created attachment 83270 [details] [review] Bug 21756: Update members/manivoice to use add_debit
Created attachment 83271 [details] [review] Bug 21756: Add deprecation warning to manualinvoice
Test Plan 1) Apply patches and run the test suit to check for regressions in tests 2) Use the manual invoice page to add a new invoice, this should work 3) As above, but use a non-existent item number and check that you get a suitable warning still.
Need rebase due to bug 21915. Also qa tools have some complains: FAIL Koha/Patron.pm FAIL pod *** ERROR: Spurious text after =cut in file Koha/Patron.pm FAIL members/maninvoice.pl FAIL valid (Missing operator before $error?) Global symbol "$template" requires explicit package name (did you forget to declare "my $template"?) Scalar found where operator expected Can't redeclare "my" in "my" members/maninvoice.pl has too many errors. Global symbol "$cookie" requires explicit package name (did you forget to declare "my $cookie"?) Global symbol "$loggedinuser" requires explicit package name (did you forget to declare "my $loggedinuser"?) Global symbol "$error" requires explicit package name (did you forget to declare "my $error"?) "my" variable $input masks earlier declaration in same scope Type of arg 1 to Try::Tiny::catch must be block or sub {} (not reference constructor) syntax error
Created attachment 84729 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`.
Created attachment 84730 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`.
Created attachment 84731 [details] [review] Bug 21756: Replace manualinvoice with add_debit in tests
Created attachment 84732 [details] [review] Bug 21756: Update members/manivoice to use add_debit
Created attachment 84733 [details] [review] Bug 21756: Add deprecation warning to manualinvoice
Rebased on master
I am still getting this fron QA tools: FAIL members/maninvoice.pl FAIL valid (Missing operator before $error?) Global symbol "$template" requires explicit package name (did you forget to declare "my $template"?) Scalar found where operator expected Can't redeclare "my" in "my" members/maninvoice.pl has too many errors. Global symbol "$cookie" requires explicit package name (did you forget to declare "my $cookie"?) Global symbol "$loggedinuser" requires explicit package name (did you forget to declare "my $loggedinuser"?) Global symbol "$error" requires explicit package name (did you forget to declare "my $error"?) "my" variable $input masks earlier declaration in same scope Type of arg 1 to Try::Tiny::catch must be block or sub {} (not reference constructor) syntax error Also test don't pass: t/db_dependent/Circulation/NoIssuesChargeGuarantees.t .. 1/6 # Failed test 'Got correct offset type' # at t/db_dependent/Circulation/NoIssuesChargeGuarantees.t line 81. # got: 'Lost Item' # expected: 'Manual Debit' # Failed test 'No tests run for subtest "auto_too_much_oweing | OPACFineNoRenewalsBlockAutoRenew"' # at t/db_dependent/Circulation.t line 703. Can't use string ("FU") as a subroutine ref while "strict refs" in use at t/db_dependent/Circulation.t line 668.
Created attachment 85320 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`.
Created attachment 85321 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`.
Created attachment 85322 [details] [review] Bug 21756: Replace manualinvoice with add_debit in tests
Created attachment 85323 [details] [review] Bug 21756: Update members/manivoice to use add_debit
Created attachment 85324 [details] [review] Bug 21756: Add deprecation warning to manualinvoice
Created attachment 85325 [details] [review] Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85326 [details] [review] Bug 21756: (QA follow-up) Fixes for rebase Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85327 [details] [review] Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Sorted the issues with a series of follow-ups and I ran the whole test suit against it all again to check everything passed. Thanks for the QA effort Josef, back to you :)
\o/
Created attachment 85350 [details] [review] Bug 21756: (QA follow-up) Fix Circulation.t
I am sorry, but the tests are still not passing: t/db_dependent/Koha/Patrons.t .. 10/33 DBD::mysql::st execute failed: Field 'type' doesn't have a default value [for Statement "INSERT INTO `account_offsets` ( `amount`, `debit_id`) VALUES ( ?, ? )" with ParamValues: 0=5.000000, 1='68'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. # No tests run! # Failed test 'No tests run for subtest "add_enrolment_fee_if_needed"' # at t/db_dependent/Koha/Patrons.t line 473. t/db_dependent/Koha/Holds.t .. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT `account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types` (`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `account_offsets` ( `amount`, `debit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=42, 1='69', 2='Hold Expired'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. # Looks like you planned 4 tests but ran 3. # Failed test 'charge_cancel_fee parameter' # at t/db_dependent/Koha/Holds.t line 134. I think that some new values should be added to account_offset_types...
(In reply to Josef Moravec from comment #36) > I am sorry, but the tests are still not passing: > > t/db_dependent/Koha/Patrons.t .. 10/33 DBD::mysql::st execute failed: Field > 'type' doesn't have a default value [for Statement "INSERT INTO > `account_offsets` ( `amount`, `debit_id`) VALUES ( ?, ? )" with ParamValues: > 0=5.000000, 1='68'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. > # No tests run! > > # Failed test 'No tests run for subtest "add_enrolment_fee_if_needed"' > # at t/db_dependent/Koha/Patrons.t line 473. > > t/db_dependent/Koha/Holds.t .. DBD::mysql::st execute failed: Cannot add or > update a child row: a foreign key constraint fails > (`koha_kohadev`.`account_offsets`, CONSTRAINT `account_offsets_ibfk_t` > FOREIGN KEY (`type`) REFERENCES `account_offset_types` (`type`) ON DELETE > CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `account_offsets` ( > `amount`, `debit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=42, > 1='69', 2='Hold Expired'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line > 1832. > # Looks like you planned 4 tests but ran 3. > > # Failed test 'charge_cancel_fee parameter' > # at t/db_dependent/Koha/Holds.t line 134. > > > I think that some new values should be added to account_offset_types... The tests pass for me - I wonder what the difference could be? Just applied, reset_all and ran them. The only issue I see is lots of warnings in Circulation.t, but I tihnk there was another bug for those.
I'm going to take another look at this again in the morning with fresh eyes. The final follow-up fix you've added Josef highlights a logical error to me... Feels like accounttype should not be getting set after the add_debit call at all.. seems like it's cheating the test result. Anywho, I'll investigate.. bet it's another thing that crept in with a rebase.
Having looked again this morning, I'm OK with the accounttype being altered in the test there.. it mimics the behaviour of the FU -> F transition that happens in C4::Overdues. So.. I'm re-running the full test suit one last time in a totally fresh koha-testing-docker to see if I can replicate your failures.. I'll report back once the test run has completed.
Ack.. thought I'd double check I'd caught all counts of manualinvoice and it seems a few new ones have been introduced since I wrote this patchset.. bear with my whilst I do yet another followup!
Created attachment 85420 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`.
Created attachment 85421 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`.
Created attachment 85422 [details] [review] Bug 21756: Replace manualinvoice with add_debit in tests
Created attachment 85423 [details] [review] Bug 21756: Update members/manivoice to use add_debit
Created attachment 85424 [details] [review] Bug 21756: Add deprecation warning to manualinvoice
Created attachment 85425 [details] [review] Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85426 [details] [review] Bug 21756: (QA follow-up) Fixes for rebase Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85427 [details] [review] Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85428 [details] [review] Bug 21756: (QA follow-up) Fix Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85429 [details] [review] Bug 21756: (follow-up) Add test for deprecation warning Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85430 [details] [review] Bug 21756: (follow-up) Replace newly introduced manualinvoice call Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Yup, I can't replicate that test failure at all.. sorry Josef.. any chance you could have another go or help me replicate it.
Created attachment 85505 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`.
Created attachment 85506 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`.
Created attachment 85507 [details] [review] Bug 21756: Replace manualinvoice with add_debit in tests
Created attachment 85508 [details] [review] Bug 21756: Add deprecation warning to manualinvoice
Created attachment 85509 [details] [review] Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85510 [details] [review] Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85511 [details] [review] Bug 21756: (QA follow-up) Fix Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85512 [details] [review] Bug 21756: (follow-up) Add test for deprecation warning Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85513 [details] [review] Bug 21756: (follow-up) Replace newly introduced manualinvoice call Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85514 [details] [review] Bug 21756: (QA follow-up) Add `Account Management Fee` mapping Required for add_enrolement_fee_if_needed within Koha::Patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85515 [details] [review] Bug 21756: (QA follow-up) Add offset_types to database Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Sorry, still not perfect... t/db_dependent/Koha/Patrons.t .......................... 12/33 DBD::mysql::st execute failed: Data too long for column 'type' at row 1 [for Statement "INSERT INTO `account_offsets` ( `amount`, `debit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=5.000000, 1='408', 2='Account Management Fee'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. # No tests run! # Failed test 'No tests run for subtest "add_enrolment_fee_if_needed"' # at t/db_dependent/Koha/Patrons.t line 473. DBIx::Class::Storage::DBI::_dbh_execute(): Data too long for column 'type' at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 155 # Looks like your test exited with 255 just after 14. 'type' is of type VARCHAR (16), so 'Account Management Fee' is too long here also one type here: FAIL t/db_dependent/Accounts.t FAIL spelling recieved ==> received
Created attachment 85638 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`.
Created attachment 85639 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`.
Created attachment 85640 [details] [review] Bug 21756: Replace manualinvoice with add_debit in tests
Created attachment 85641 [details] [review] Bug 21756: Add deprecation warning to manualinvoice
Created attachment 85642 [details] [review] Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85643 [details] [review] Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85644 [details] [review] Bug 21756: (QA follow-up) Fix Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85645 [details] [review] Bug 21756: (follow-up) Add test for deprecation warning Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85646 [details] [review] Bug 21756: (follow-up) Replace newly introduced manualinvoice call Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85647 [details] [review] Bug 21756: (QA follow-up) Add `Account Fee` mapping Required for add_enrolement_fee_if_needed within Koha::Patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 85648 [details] [review] Bug 21756: (QA follow-up) Add offset_types to database Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Dopey mistake corrected.
Created attachment 85654 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85655 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85656 [details] [review] Bug 21756: Replace manualinvoice with add_debit in tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85657 [details] [review] Bug 21756: Add deprecation warning to manualinvoice https://bugs.koha-community.org/show_bug.cgi?id=21756 Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85658 [details] [review] Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85659 [details] [review] Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85660 [details] [review] Bug 21756: (QA follow-up) Fix Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85661 [details] [review] Bug 21756: (follow-up) Add test for deprecation warning Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85662 [details] [review] Bug 21756: (follow-up) Replace newly introduced manualinvoice call Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85663 [details] [review] Bug 21756: (QA follow-up) Add `Account Fee` mapping Required for add_enrolement_fee_if_needed within Koha::Patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85664 [details] [review] Bug 21756: (QA follow-up) Add offset_types to database Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85665 [details] [review] Bug 21756: (QA follow-up) Add missing offset_types to installer file Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 86265 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`.
Created attachment 86266 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`.
Created attachment 86267 [details] [review] Bug 21756: Replace manualinvoice with add_debit in tests
Created attachment 86268 [details] [review] Bug 21756: Add deprecation warning to manualinvoice
Created attachment 86269 [details] [review] Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 86270 [details] [review] Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 86271 [details] [review] Bug 21756: (QA follow-up) Fix Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 86272 [details] [review] Bug 21756: (follow-up) Add test for deprecation warning Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 86273 [details] [review] Bug 21756: (follow-up) Replace newly introduced manualinvoice call Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 86274 [details] [review] Bug 21756: (QA follow-up) Add `Account Fee` mapping Required for add_enrolement_fee_if_needed within Koha::Patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 86275 [details] [review] Bug 21756: (QA follow-up) Add offset_types to database Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 86276 [details] [review] Bug 21756: (QA follow-up) Add offest types to installer file Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Freshly rebased
Looks like we lost the sign off lines on the latest patches. I also only see Josef, did these skip SO and go straight to QA?
Ooh, I thought Tomas was doing a final QA as both Josef and I worked on it and in effect signed off each others work.
Setting to SO for final QA pass
Created attachment 86441 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 86442 [details] [review] Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 86443 [details] [review] Bug 21756: Replace manualinvoice with add_debit in tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 86444 [details] [review] Bug 21756: Add deprecation warning to manualinvoice https://bugs.koha-community.org/show_bug.cgi?id=21756 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 86445 [details] [review] Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 86446 [details] [review] Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 86447 [details] [review] Bug 21756: (QA follow-up) Fix Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 86448 [details] [review] Bug 21756: (follow-up) Add test for deprecation warning Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 86449 [details] [review] Bug 21756: (follow-up) Replace newly introduced manualinvoice call Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 86450 [details] [review] Bug 21756: (QA follow-up) Add `Account Fee` mapping Required for add_enrolement_fee_if_needed within Koha::Patron Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 86451 [details] [review] Bug 21756: (QA follow-up) Add offset_types to database Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 86452 [details] [review] Bug 21756: (QA follow-up) Add offest types to installer file Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.