When I try to add a record to a basket from Z39.50, I can't seem to go to the next pages of results. I'm stuck on the first page. To reproduce: 1) Go to Acquisitions 2) Search for a Vendor (or add a vendor) 3) Create a new basket 4) Click 'Add to basket' 5) Choose 'from external source' 6) Search for a term (I searched for 'cats' in title and the target is Library of Congress) 7) Check the number of results (I get 1 to 20 of 20, which I find suspect, I'm pretty sure LOC has more than 20 titles containing 'cats' in their collection) 8) Check the number of results pages (I have 1 / 286) 9) Click on Next page (nothing happens) 10) Enter a page number in the 'Go to page' box and click 'Go' (I get an error message saying 'Please choose at least one external target') Can someone test and tell me if they get the same thing? Thanks!
I can confirm - the navigation is broken.
Caused by Bug 20038.
Created attachment 82569 [details] [review] Bug 21758: Navigation in Z39.50 result pages not working in Acquisitions This patch makes markup corrections to the acquisitions Z39.50 search results template so that the navigation form works correctly. Also changed: Removed invalid type attributes from style and script tags. To test, apply the patch and go to Acquisitions -> Vendor -> Basket. - Add to basket -> From an external source - Perform a Z39.50 search which will return multiple pages of results - On the search results page, use the form at the bottom of the page to navigate through results. Confirm that both the "Go" form and the next/previous buttons work.
Created attachment 82575 [details] [review] Bug 21758: Navigation in Z39.50 result pages not working in Acquisitions This patch makes markup corrections to the acquisitions Z39.50 search results template so that the navigation form works correctly. Also changed: Removed invalid type attributes from style and script tags. To test, apply the patch and go to Acquisitions -> Vendor -> Basket. - Add to basket -> From an external source - Perform a Z39.50 search which will return multiple pages of results - On the search results page, use the form at the bottom of the page to navigate through results. Confirm that both the "Go" form and the next/previous buttons work. Signed-off-by: David Nind <david@davidnind.com>
Noticed that search results displays 'Showing 1 to 20 of 20' at the start and end of every search results page. Should this display the total number of results and the place in the pagination? This doesn't affect fixing up the issue in the bug, but would be good to fix up as well if it is easy enough to do.
Created attachment 82587 [details] [review] Bug 21758: Navigation in Z39.50 result pages not working in Acquisitions This patch makes markup corrections to the acquisitions Z39.50 search results template so that the navigation form works correctly. Also changed: Removed invalid type attributes from style and script tags. To test, apply the patch and go to Acquisitions -> Vendor -> Basket. - Add to basket -> From an external source - Perform a Z39.50 search which will return multiple pages of results - On the search results page, use the form at the bottom of the page to navigate through results. Confirm that both the "Go" form and the next/previous buttons work. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Awesome work all! Pushed to master for 18.11
Doesn't apply cleanly. Please rebase for 18.05. Thanks