Work to be: 1) Move opac-user.pl holds tab content into include file 2) Add holds to to sco, use new include file 3) Add patron fines info to sco. 4) Modify script to search for and pass in patron holds
Created attachment 86331 [details] [review] Bug 21772: Move OPAC holds and account tables into .inc This patch moves the code to render the account and holds information for the patron into include files. They are loaded in the opac-user.tt and opac-account.tt templates respectively. To test: 1) Have a patron with account lines and holds 2) Notice they are displayed in the patron's detail section in the OPAC 3) Apply this patch 4) Reload the patron's detail page => SUCESS: Everything looks the same, no behaviuor or layout change. 5) Sign off Sponsored-by: City of Portsmouth Public Library
Created attachment 86332 [details] [review] Bug 21772: (follow-up) QA failed because old bootstrap button class
Created attachment 86333 [details] [review] Bug 21772: Add holds and account information to SCO This patch introduces holds and account information to the SCO page. It uses the introduced include files that are also used in OPAC (opac-user.pl and opac-account.pl). To test: 1) Have a patron that has holds and account lines 2) Enable the SCO module 3) Use the patron's cardnumber to get to its details => SUCCESS: New tabs are presented, and they display holds and account information as expected 4) Sign off :-D Sponsored-by: City of Portsmouth Public Library
Created attachment 86334 [details] [review] Bug 21772: (follow-up) Remove redundant variable Sponsored-by: City of Portsmouth Public Library
*** Bug 9047 has been marked as a duplicate of this bug. ***
Agustín, I tested the patch and the functionality works. Is it possible to include more information in the tab labels in SCO, as it is displayed in opac-user.pl? Such as: Checkouts (0) Holds (1) Fines and charges (16.99) Thanks, Sarah
Created attachment 86495 [details] [review] Bug 21772: (follow-up) Included more information on tab label for SCO
The tabs look good. I'm almost ready to sign off. At some point in my testing the SCO shut down. I think it was because the SCO was trying to edit an item as part of the normal process. I reproduced the shutdown when I tried to edit an item in the intranet. This is one of the last lines of the plack log when it shuts down: Use of uninitialized value $searchid in concatenation (.) or string at /kohadevbox/koha/cataloguing/addbiblio.pl line 853. 2019/03/12-19:48:38 Server closing! I don't see why it would be related but I'm new to testing on the sandboxes so I have to ask!
Hello Sarah, I believe that behaviour isn't related with this bug. I think somehow SCO and intranet are overwritting the others browser cookies. Please try opening each one in different browsers, or one in incognito mode. Thanks
I got the same behavior (tab closes when invoking additem.pl) when testing another bug in the sandboxes, even after clearing cookies and only using the intranet. So I guess it is unrelated to this bug. I'm signing off because your patches work. If this isn't the right thing to do, I'm sure someone will let me know!
Comment on attachment 86332 [details] [review] Bug 21772: (follow-up) QA failed because old bootstrap button class This is false positive. In opac, we still use class btn-mini as Bootstrap in opac was not upgraded to version 3 and is still using version 2
Created attachment 87042 [details] [review] Bug 21772: Move OPAC holds and account tables into .inc This patch moves the code to render the account and holds information for the patron into include files. They are loaded in the opac-user.tt and opac-account.tt templates respectively. To test: 1) Have a patron with account lines and holds 2) Notice they are displayed in the patron's detail section in the OPAC 3) Apply this patch 4) Reload the patron's detail page => SUCESS: Everything looks the same, no behaviuor or layout change. 5) Sign off Sponsored-by: City of Portsmouth Public Library Signed-off-by: Sarah Cornell <sbcornell@cityofportsmouth.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 87043 [details] [review] Bug 21772: Add holds and account information to SCO This patch introduces holds and account information to the SCO page. It uses the introduced include files that are also used in OPAC (opac-user.pl and opac-account.pl). To test: 1) Have a patron that has holds and account lines 2) Enable the SCO module 3) Use the patron's cardnumber to get to its details => SUCCESS: New tabs are presented, and they display holds and account information as expected 4) Sign off :-D Sponsored-by: City of Portsmouth Public Library Signed-off-by: Sarah Cornell <sbcornell@cityofportsmouth.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 87044 [details] [review] Bug 21772: (follow-up) Remove redundant variable Sponsored-by: City of Portsmouth Public Library Signed-off-by: Sarah Cornell <sbcornell@cityofportsmouth.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 87045 [details] [review] Bug 21772: (follow-up) Included more information on tab label for SCO Signed-off-by: Sarah Cornell <sbcornell@cityofportsmouth.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 87046 [details] [review] Bug 21772: (QA follow-up) Hide .tdlabel class in sco for consistancy with opac-user page. Test plan: 1) Compare holds table on selfcheckout and opac-user page, you will see the difference: In self checkout there are labels like Status, Pickup location, and so on in every table cell. 2) Apply the patch, the label in selfcheckout dissappear Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 87047 [details] [review] Bug 21772: (QA follow-up) Fix button class on Cancel hold button Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 87048 [details] [review] Bug 21772: (QA follow-up) Fix setting variables to PROCESS in holds Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 87064 [details] [review] Bug 21772: (follow-up) Minor markup correction and reindentation This patch makes one minor markup correction: In HTML5 <tfoot> must be after <tbody>. Previously the opposite was true. I've also done a little bit of opinionated reindentation. There should be no changes visible to the user from this patch.
I hope you don't mind the minor follow-up. I can submit on a separate bug if that's better.
Created attachment 87067 [details] [review] Bug 21772: (follow-up) Minor markup correction and reindentation This patch makes one minor markup correction: In HTML5 <tfoot> must be after <tbody>. Previously the opposite was true. I've also done a little bit of opinionated reindentation. There should be no changes visible to the user from this patch. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
(In reply to Owen Leonard from comment #20) > I hope you don't mind the minor follow-up. I can submit on a separate bug if > that's better. That's OK.
(In reply to Owen Leonard from comment #20) > I hope you don't mind the minor follow-up. I can submit on a separate bug if > that's better. Looks great, thanks :D
Awesome work all! Pushed to master for 19.05
Enhancement, will not be backported to 18.11.x series.