Script type attributes should be removed from js_includes. CDATA markers can also be removed.
Created attachment 82044 [details] [review] Bug 21784: Clean up js_includes.inc This patch cleans up js_includes.inc by removing script "type" attributes which are now invalid HTML. The patch also removes "CDATA" markers from script blocks. They have been unnecessary since we stopped using an XHTML doctype. To test, apply the patch and look at various pages in the staff client to confirm that no JavaScript-driven interactions are broken.
Created attachment 88528 [details] [review] Bug 21784: Clean up js_includes.inc This patch cleans up js_includes.inc by removing script "type" attributes which are now invalid HTML. The patch also removes "CDATA" markers from script blocks. They have been unnecessary since we stopped using an XHTML doctype. To test, apply the patch and look at various pages in the staff client to confirm that no JavaScript-driven interactions are broken. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 88568 [details] [review] Bug 21784: Clean up js_includes.inc This patch cleans up js_includes.inc by removing script "type" attributes which are now invalid HTML. The patch also removes "CDATA" markers from script blocks. They have been unnecessary since we stopped using an XHTML doctype. To test, apply the patch and look at various pages in the staff client to confirm that no JavaScript-driven interactions are broken. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported into 18.11.x series.