Bug 19066 introduces the new column.
Created attachment 82094 [details] [review] Bug 21788: Unit tests This patch refactors the tests related to ProcessOfflinePayment and adds checks for setting branchcode on the account line. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: branchcode is not set
Created attachment 82095 [details] [review] Bug 21788: Make ProcessOfflinePayment pass the library_id parameter To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: branchcode is not set - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass! - Sign off :-D
Created attachment 82285 [details] [review] Bug 21788: Unit tests This patch refactors the tests related to ProcessOfflinePayment and adds checks for setting branchcode on the account line. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: branchcode is not set Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 82286 [details] [review] Bug 21788: Make ProcessOfflinePayment pass the library_id parameter To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: branchcode is not set - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 83721 [details] [review] Bug 21788: Unit tests This patch refactors the tests related to ProcessOfflinePayment and adds checks for setting branchcode on the account line. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: branchcode is not set Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 83722 [details] [review] Bug 21788: Make ProcessOfflinePayment pass the library_id parameter To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: branchcode is not set - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 19.05
Depends on enhancement in bug 19066, will not be backported to 18.11.x series.