Bug 21805 - Duplicate include file in search results template causes JS error
Summary: Duplicate include file in search results template causes JS error
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-09 18:56 UTC by Owen Leonard
Modified: 2019-10-14 19:57 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21805: Duplicate include file in search results template causes JS error (1.39 KB, patch)
2018-11-09 19:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21805: Duplicate include file in search results template causes JS error (1.46 KB, patch)
2018-11-09 20:01 UTC, Pierre-Marc Thibault
Details | Diff | Splinter Review
Bug 21805: Duplicate include file in search results template causes JS error (1.55 KB, patch)
2018-11-14 15:02 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-11-09 18:56:31 UTC
There is a duplicate include of browser-strings.inc in results.tt. Probably a merge error. The first one should be removed because it needs to be loaded after the global JS includes.
Comment 1 Owen Leonard 2018-11-09 19:04:56 UTC Comment hidden (obsolete)
Comment 2 Pierre-Marc Thibault 2018-11-09 20:01:24 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2018-11-14 15:02:53 UTC
Created attachment 82341 [details] [review]
Bug 21805: Duplicate include file in search results template causes JS error

This patch removes a redundant include file, browser-strings.inc, from
the top of the staff client search results template. The
correctly-placed include is in the JavaScript block at the bottom of the
template. The duplication causes a JavaScript error which can be seen in
the browser console.

To test, apply the patch and peform a catalog search in the staff
client. Open the browser console and confirm that there are no errors.

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Nick Clemens 2018-11-15 12:49:36 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-11-23 16:09:00 UTC
Issue not in 18.05.x series.