The following condition in xsl detail opac and staff looks at $j for field 111 but not for field 711 while it should too. The condition can be written a bit easier to read (without self, parent, etc.) <xsl:if test="marc:subfield[@code='4' or @code='e'][not(parent::*[@tag=111])] or (self::*[@tag=111] and marc:subfield[@code='4' or @code='j'][. != ''])">
Created attachment 82222 [details] [review] Bug 21808: Field 711 is not handled correctly in showAuthor XSLT for relator term or code The test should check $4 or $e for fields ne 111,711. And should check $4 or $j for 111,711. Test plan: Edit a record, add a meeting in 711 without $4 but with $j. Without this patch the term is not visible, with this patch it is.
Created attachment 82418 [details] [review] Bug 21808: Field 711 is not handled correctly in showAuthor XSLT for relator term or code The test should check $4 or $e for fields ne 111,711. And should check $4 or $j for 111,711. Test plan: Edit a record, add a meeting in 711 without $4 but with $j. Without this patch the term is not visible, with this patch it is. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Created attachment 84699 [details] [review] Bug 21808: Field 711 is not handled correctly in showAuthor XSLT for relator term or code The test should check $4 or $e for fields ne 111,711. And should check $4 or $j for 111,711. Test plan: Edit a record, add a meeting in 711 without $4 but with $j. Without this patch the term is not visible, with this patch it is. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(In reply to Kyle M Hall from comment #3) > Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Thx
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
backported to 18.05.x for 18.05.09
Pushed to 17.11.x for 17.11.15