If the language-chooser is shown and a system preference search returns a large number of results the last submit button on the page can be hidden behind the language menu.
Created attachment 82243 [details] [review] Bug 21814: System preferences save button can be hidden by language menu This patch modifies the staff client CSS to give pages enough of a bottom margin that the language footer will not obscure controls appearing at the bottom of the page. To test, apply the patch and regenerate the staff client CSS. You must have one or more translations installed and enabled. StaffLangSelectorMode should be set to display the language menu in the footer. Go to Administration and search for 'opac.' Scroll to the bottom of the page and confirm that the last submit button is not hidden by the language menu.
Created attachment 82362 [details] [review] Bug 21814: System preferences save button can be hidden by language menu This patch modifies the staff client CSS to give pages enough of a bottom margin that the language footer will not obscure controls appearing at the bottom of the page. To test, apply the patch and regenerate the staff client CSS. You must have one or more translations installed and enabled. StaffLangSelectorMode should be set to display the language menu in the footer. Go to Administration and search for 'opac.' Scroll to the bottom of the page and confirm that the last submit button is not hidden by the language menu. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Hi Owen, Patch works as expected but shouldn't the margin be equal to (or at least based on) the height of navbar ? For the navbar we have min-height: 20px but it's actually a bit more (30.4px for me) and the patch sets a margin of 3em. I'm not familiar with SCSS, but this looks like a good candidate for variables. Something like this: :root { $navbar_height: 30px; } .navbar { height: $navbar_height; } .main { margin-bottom: $navbar_height; } What do you think ?
Created attachment 82370 [details] [review] Bug 21814: (follow-up) System preferences save button can be hidden by language menu This follow-up implements the same change by defining a variable to be used as the minimum height of the language footer navbar. A calculation is done on this value to set the bottom margin of the main area of the page. To test, apply the patch and rebuild the staff client CSS. Clear your browser cache if necessary. View the system preferences page again and confirm that the bug is still fixed.
Created attachment 82371 [details] [review] Bug 21814: System preferences save button can be hidden by language menu This patch modifies the staff client CSS to give pages enough of a bottom margin that the language footer will not obscure controls appearing at the bottom of the page. To test, apply the patch and regenerate the staff client CSS. You must have one or more translations installed and enabled. StaffLangSelectorMode should be set to display the language menu in the footer. Go to Administration and search for 'opac.' Scroll to the bottom of the page and confirm that the last submit button is not hidden by the language menu. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 82372 [details] [review] Bug 21814: (follow-up) System preferences save button can be hidden by language menu This follow-up implements the same change by defining a variable to be used as the minimum height of the language footer navbar. A calculation is done on this value to set the bottom margin of the main area of the page. To test, apply the patch and rebuild the staff client CSS. Clear your browser cache if necessary. View the system preferences page again and confirm that the bug is still fixed. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Awesome work all! Pushed to master for 18.11
Is this an issue in 18.05.x branch Owen?
(In reply to Martin Renvoize from comment #8) > Is this an issue in 18.05.x branch Owen? It doesn't appear to be.
Thanks :)