Bug 21820 - Zebraqueue should not be added to when only Elasticsearch is used
Summary: Zebraqueue should not be added to when only Elasticsearch is used
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching - Elasticsearch (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
: 25710 29147 (view as bug list)
Depends on:
Blocks: 25710
  Show dependency treegraph
 
Reported: 2018-11-13 13:27 UTC by Martin Renvoize
Modified: 2024-03-24 23:16 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2018-11-13 13:27:28 UTC
In bug 20244 we identified that the zebraqueue is still being appended to when the searchengine preference is set to ElasticSearch.. unfortunately zebra may still be in use in parallel to Elastic to provide a public SRU/z3950 gateway.. as such we can't bind on just the syspref to know whether we should stop adding to the zebraqueue or not.
Comment 1 Katrin Fischer 2020-06-11 10:32:11 UTC
So I think maybe a new preference or option?
Comment 2 Fridolin Somers 2020-09-02 14:46:01 UTC
(In reply to Katrin Fischer from comment #1)
> So I think maybe a new preference or option?

Or a new value to SearchEngine : 
ES alone, ES + Zebra, Zebra alone
Comment 3 David Cook 2020-09-03 00:21:50 UTC
(In reply to Fridolin SOMERS from comment #2)
> (In reply to Katrin Fischer from comment #1)
> > So I think maybe a new preference or option?
> 
> Or a new value to SearchEngine : 
> ES alone, ES + Zebra, Zebra alone

That's probably more trouble than it's worth? 

I reckon a new system preference makes more sense?
Comment 4 Katrin Fischer 2020-10-18 16:58:06 UTC
I think a new option to the existing or a new pref would both work and be about the same amount of trouble :)
Comment 5 Fridolin Somers 2020-10-20 09:41:17 UTC
(In reply to Katrin Fischer from comment #4)
> I think a new option to the existing or a new pref would both work and be
> about the same amount of trouble :)

Thinking about it, actual pref "searchengine" is alread used.

A new pref whould be less disturbing.
Maybe EnableZebraQueue ?
Comment 6 Katrin Fischer 2022-02-19 23:46:30 UTC
*** Bug 29147 has been marked as a duplicate of this bug. ***
Comment 7 Katrin Fischer 2022-03-15 08:29:37 UTC
*** Bug 25710 has been marked as a duplicate of this bug. ***
Comment 8 Nick Clemens (kidclamp) 2023-10-17 20:45:55 UTC
333     #FIXME Current behaviour is to index Zebra when using ES, at some point we should stop
334     Koha::SearchEngine::Zebra::Indexer::index_records( $self, $record_numbers, $op, $server, undef );

Yeah, I think we are at the point :-)
Comment 9 Liz Rea 2023-10-17 20:46:53 UTC
let's make it a kconf flag, that way if you need it for whatever reason, a fallback is available
Comment 10 David Cook 2024-03-24 23:16:19 UTC
(In reply to Nick Clemens from comment #8)
> Yeah, I think we are at the point :-)

Agreed!

We're (finally) starting to use Elasticsearch more with Koha, and we're keen to disable Zebra completely for those sites using Elastic.

(In reply to Liz Rea from comment #9)
> let's make it a kconf flag, that way if you need it for whatever reason, a
> fallback is available

I like that idea. We can default it to Elasticsearch+Zebra for backwards compatibility, but have an option to not add to the zebraqueue. 

Another thing to consider is /etc/init.d/koha-common. We might want to add a --zebra option for koha-list, so that koha-zebra and koha-indexer are only invoked for Zebra-enabled instances.