In bug 20244 we identified that the zebraqueue is still being appended to when the searchengine preference is set to ElasticSearch.. unfortunately zebra may still be in use in parallel to Elastic to provide a public SRU/z3950 gateway.. as such we can't bind on just the syspref to know whether we should stop adding to the zebraqueue or not.
So I think maybe a new preference or option?
(In reply to Katrin Fischer from comment #1) > So I think maybe a new preference or option? Or a new value to SearchEngine : ES alone, ES + Zebra, Zebra alone
(In reply to Fridolin SOMERS from comment #2) > (In reply to Katrin Fischer from comment #1) > > So I think maybe a new preference or option? > > Or a new value to SearchEngine : > ES alone, ES + Zebra, Zebra alone That's probably more trouble than it's worth? I reckon a new system preference makes more sense?
I think a new option to the existing or a new pref would both work and be about the same amount of trouble :)
(In reply to Katrin Fischer from comment #4) > I think a new option to the existing or a new pref would both work and be > about the same amount of trouble :) Thinking about it, actual pref "searchengine" is alread used. A new pref whould be less disturbing. Maybe EnableZebraQueue ?
*** Bug 29147 has been marked as a duplicate of this bug. ***
*** Bug 25710 has been marked as a duplicate of this bug. ***
333 #FIXME Current behaviour is to index Zebra when using ES, at some point we should stop 334 Koha::SearchEngine::Zebra::Indexer::index_records( $self, $record_numbers, $op, $server, undef ); Yeah, I think we are at the point :-)
let's make it a kconf flag, that way if you need it for whatever reason, a fallback is available
(In reply to Nick Clemens from comment #8) > Yeah, I think we are at the point :-) Agreed! We're (finally) starting to use Elasticsearch more with Koha, and we're keen to disable Zebra completely for those sites using Elastic. (In reply to Liz Rea from comment #9) > let's make it a kconf flag, that way if you need it for whatever reason, a > fallback is available I like that idea. We can default it to Elasticsearch+Zebra for backwards compatibility, but have an option to not add to the zebraqueue. Another thing to consider is /etc/init.d/koha-common. We might want to add a --zebra option for koha-list, so that koha-zebra and koha-indexer are only invoked for Zebra-enabled instances.