Bug 21838 - Wrong alignment of instructors in course reserves
Summary: Wrong alignment of instructors in course reserves
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-14 21:07 UTC by Tomás Cohen Arazi
Modified: 2020-06-04 20:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot (Error) (53.82 KB, image/png)
2018-11-14 21:08 UTC, Tomás Cohen Arazi
Details
Bug 21838: Wrong alignment of instructors in course reserves (6.43 KB, patch)
2018-11-15 13:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21838: Wrong alignment of instructors in course reserves (6.50 KB, patch)
2018-11-16 01:31 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 21838: Wrong alignment of instructors in course reserves (6.54 KB, patch)
2018-11-16 06:58 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 21838: Wrong alignment of instructors in course reserves (6.60 KB, patch)
2018-11-16 07:01 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2018-11-14 21:07:54 UTC
If you add more than one instructor, they are not aligned correctly.
Comment 1 Tomás Cohen Arazi 2018-11-14 21:08:47 UTC
Created attachment 82348 [details]
Screenshot (Error)
Comment 2 Owen Leonard 2018-11-15 13:44:34 UTC
Created attachment 82360 [details] [review]
Bug 21838: Wrong alignment of instructors in course reserves

This patch adds CSS to course reserve pages so that multiple instructors
on a course are displayed well.

To test, apply the patch and:

 - Add or edit a course.
   - Test adding and removing instructors, saving, and adding and removing
     again.
 - View a course with multiple instructors and confirm that they are
   displayed well.
Comment 3 Tomás Cohen Arazi 2018-11-16 01:31:47 UTC
Created attachment 82376 [details] [review]
Bug 21838: Wrong alignment of instructors in course reserves

This patch adds CSS to course reserve pages so that multiple instructors
on a course are displayed well.

To test, apply the patch and:

 - Add or edit a course.
   - Test adding and removing instructors, saving, and adding and removing
     again.
 - View a course with multiple instructors and confirm that they are
   displayed well.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Awesome, Owen :-D
Comment 4 Marcel de Rooy 2018-11-16 06:58:28 UTC Comment hidden (obsolete)
Comment 5 Marcel de Rooy 2018-11-16 07:01:20 UTC
Created attachment 82380 [details] [review]
Bug 21838: Wrong alignment of instructors in course reserves

This patch adds CSS to course reserve pages so that multiple instructors
on a course are displayed well.

To test, apply the patch and:

 - Add or edit a course.
   - Test adding and removing instructors, saving, and adding and removing
     again.
 - View a course with multiple instructors and confirm that they are
   displayed well.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Awesome, Owen :-D

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Nick Clemens 2018-11-16 13:11:01 UTC
Awesome work all!

Pushed to master for 18.11
Comment 7 Lucas Gass 2018-12-04 19:53:37 UTC
unable to backport cleanly to 18.05. failed qa test:

 FAIL	koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt
   OK	  forbidden patterns
   OK	  git manipulation
   OK	  spelling
   OK	  tt_valid
   FAIL	  valid_template
		Attempt to reload Koha/Template/Plugin/Koha.pm aborted.
Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Plugins.pm line 206.