If you add more than one instructor, they are not aligned correctly.
Created attachment 82348 [details] Screenshot (Error)
Created attachment 82360 [details] [review] Bug 21838: Wrong alignment of instructors in course reserves This patch adds CSS to course reserve pages so that multiple instructors on a course are displayed well. To test, apply the patch and: - Add or edit a course. - Test adding and removing instructors, saving, and adding and removing again. - View a course with multiple instructors and confirm that they are displayed well.
Created attachment 82376 [details] [review] Bug 21838: Wrong alignment of instructors in course reserves This patch adds CSS to course reserve pages so that multiple instructors on a course are displayed well. To test, apply the patch and: - Add or edit a course. - Test adding and removing instructors, saving, and adding and removing again. - View a course with multiple instructors and confirm that they are displayed well. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Awesome, Owen :-D
Created attachment 82378 [details] [review] Bug 21838: Wrong alignment of instructors in course reserves This patch adds CSS to course reserve pages so that multiple instructors on a course are displayed well. To test, apply the patch and: - Add or edit a course. - Test adding and removing instructors, saving, and adding and removing again. - View a course with multiple instructors and confirm that they are displayed well. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Awesome, Owen :-D
Created attachment 82380 [details] [review] Bug 21838: Wrong alignment of instructors in course reserves This patch adds CSS to course reserve pages so that multiple instructors on a course are displayed well. To test, apply the patch and: - Add or edit a course. - Test adding and removing instructors, saving, and adding and removing again. - View a course with multiple instructors and confirm that they are displayed well. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Awesome, Owen :-D Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Awesome work all! Pushed to master for 18.11
unable to backport cleanly to 18.05. failed qa test: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid FAIL valid_template Attempt to reload Koha/Template/Plugin/Koha.pm aborted. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Plugins.pm line 206.