Found while translating: Are you sure you wish to remove this item from it's rota
intranet-tmpl/prog/en/modules/ill/ill-requests.tt:13 Bibliograpic record ID
Some possible issue here, as this showed up as a template variable to translate and not as %s: intranet-tmpl/prog/en/modules/acqui/basket.tt:547 Can't cancel order, ([% books_loo.holds_on_order | html %]) holds are linked with this order cancel holds first
(In reply to Katrin Fischer from comment #2) > Some possible issue here, as this showed up as a template variable to > translate and not as %s: > > intranet-tmpl/prog/en/modules/acqui/basket.tt:547 > Can't cancel order, ([% books_loo.holds_on_order | html %]) holds are linked > with this order cancel holds first Same here: parcel.tt Can't cancel order, ([% loop_order.holds_on_order | html %]) holds are linked with this order cancel holds first
intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt:32 Print this slabel
I think issues in comment#2 and comment#3 can be left out here, no typos, but something we need to have a look at another time.
Created attachment 84036 [details] [review] Bug 21840: Fixed some typos in the templates intranet-tmpl/prog/en/modules/ill/ill-requests.tt:13 Bibliograpic record ID --> Bibliographic record ID intranet-tmpl/prog/en/modules/acqui/basket.tt:547 Can't cancel order, ([% books_loo.holds_on_order | html %]) holds are linked with this order cancel holds first --> ... with this order. Cancel holds first intranet-tmpl/prog/en/modules/acqui/parcel.tt Can't cancel order, ([% loop_order.holds_on_order | html %]) holds are linked with this order cancel holds first --> ... with this order. Cancel holds first intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt:32 Print this slabel --> Print this label Test plan: 1. Check that the fixes in the patch are correct
Created attachment 84128 [details] [review] Bug 21840: Fixed some typos in the templates intranet-tmpl/prog/en/modules/ill/ill-requests.tt:13 Bibliograpic record ID --> Bibliographic record ID intranet-tmpl/prog/en/modules/acqui/basket.tt:547 Can't cancel order, ([% books_loo.holds_on_order | html %]) holds are linked with this order cancel holds first --> ... with this order. Cancel holds first intranet-tmpl/prog/en/modules/acqui/parcel.tt Can't cancel order, ([% loop_order.holds_on_order | html %]) holds are linked with this order cancel holds first --> ... with this order. Cancel holds first intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt:32 Print this slabel --> Print this label Test plan: 1. Check that the fixes in the patch are correct Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 84867 [details] [review] Bug 21840: Fixed some typos in the templates intranet-tmpl/prog/en/modules/ill/ill-requests.tt:13 Bibliograpic record ID --> Bibliographic record ID intranet-tmpl/prog/en/modules/acqui/basket.tt:547 Can't cancel order, ([% books_loo.holds_on_order | html %]) holds are linked with this order cancel holds first --> ... with this order. Cancel holds first intranet-tmpl/prog/en/modules/acqui/parcel.tt Can't cancel order, ([% loop_order.holds_on_order | html %]) holds are linked with this order cancel holds first --> ... with this order. Cancel holds first intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt:32 Print this slabel --> Print this label Test plan: 1. Check that the fixes in the patch are correct Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Sane changes, no regressions. Passing QA
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
backported to 18.05.x for 18.05.09
I dont backport to 17.11.x to avoid translation work