Rather than getting the description in the script and passing, we should just use the tmeplate plugin to get the description from the category code. To recreate: 1 - Find a patron, note their category 2 - Visit Tools - Batch patron modification 3 - Enter barcode of patron above 4 - Note category does not show in the display of patrons to be modified 5 - Apply patch 6 - Reload the page, note the patron category displays 7 - Modify the patron (anything but category) 8 - Check that category still diplays correctly in results
Created attachment 82415 [details] [review] Bug 21854: Use template plugin to display category description Rather than getting the description in the script and passing, we should just use the tmeplate plugin to get the description from the category code. To test: 1 - Find a patron, note their category 2 - Visit Tools - Batch patron modification 3 - Enter barcode of patron above 4 - Note category does not show in the display of patrons to be modified 5 - Apply patch 6 - Reload the page, note the patron category displays 7 - Modify the patron (anything but category) 8 - Check that category still diplays correctly in results
Created attachment 82417 [details] [review] Bug 21854: Use template plugin to display category description Rather than getting the description in the script and passing, we should just use the tmeplate plugin to get the description from the category code. To test: 1 - Find a patron, note their category 2 - Visit Tools - Batch patron modification 3 - Enter barcode of patron above 4 - Note category does not show in the display of patrons to be modified 5 - Apply patch 6 - Reload the page, note the patron category displays 7 - Modify the patron (anything but category) 8 - Check that category still diplays correctly in results Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Created attachment 82421 [details] [review] Bug 21854: Use template plugin to display category description Rather than getting the description in the script and passing, we should just use the tmeplate plugin to get the description from the category code. To test: 1 - Find a patron, note their category 2 - Visit Tools - Batch patron modification 3 - Enter barcode of patron above 4 - Note category does not show in the display of patrons to be modified 5 - Apply patch 6 - Reload the page, note the patron category displays 7 - Modify the patron (anything but category) 8 - Check that category still diplays correctly in results Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Andreas Roussos <arouss1980@gmail.com>
Created attachment 82548 [details] [review] Bug 21854: Use template plugin to display category description Rather than getting the description in the script and passing, we should just use the tmeplate plugin to get the description from the category code. To test: 1 - Find a patron, note their category 2 - Visit Tools - Batch patron modification 3 - Enter barcode of patron above 4 - Note category does not show in the display of patrons to be modified 5 - Apply patch 6 - Reload the page, note the patron category displays 7 - Modify the patron (anything but category) 8 - Check that category still diplays correctly in results Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Andreas Roussos <arouss1980@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Awesome work all! Pushed to master for 18.11
Backported to 18.05 for 18.05.07
Pushed to 17.11.x for 17.11.13