System preference now reads: opac.pref#PatronSelfRegistrationVerifyByEmail# <br><strong>NOTE:</strong> This system preference requires the <code>misc/cronjobs/delete_unverified_opac_registrations.pl</code> cronjob. Ask your system administrator to schedule it. I think this cronjob has been deprecated in favor of cleanup_database. We should remove the deprecated Cronjob next release and change the pref description.
Created attachment 84041 [details] [review] Bug 21855: Changed "deprecated delete_unverified_opac_registrations.pl cronjob" to "cleanup_database" To Find Fix: 1. Go to Koha Administration 2. Search PatronSelfRegistrationVerifyByEmail 3. Verify that NOTE now says "system preference requires the cleanup_database ..."
Created attachment 84044 [details] [review] Bug 21855: Changed "deprecated delete_unverified_opac_registrations.pl cronjob" to "cleanup_database" To Find Fix: 1. Go to Koha Administration 2. Search PatronSelfRegistrationVerifyByEmail 3. Verify that NOTE now says "system preference requires the cleanup_database ..."
Created attachment 84095 [details] [review] Bug 21855: Changed "deprecated delete_unverified_opac_registrations.pl cronjob" to "cleanup_database" To Find Fix: 1. Go to Koha Administration 2. Search PatronSelfRegistrationVerifyByEmail 3. Verify that NOTE now says "system preference requires the cleanup_database ..." Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This went a little further in removing the old script as well. I've looked it up - we added the deprecation warning on 2015-07-28. So I think it's about time. Olivia, if you'd like to, it would be nice if you could add a note to the "Text to go in the release notes" field describing the change (old script removed, please use... or something like that)
Created attachment 84225 [details] [review] Bug 21855: Changed "deprecated delete_unverified_opac_registrations.pl cronjob" to "cleanup_database" To Find Fix: 1. Go to Koha Administration 2. Search PatronSelfRegistrationVerifyByEmail 3. Verify that NOTE now says "system preference requires the cleanup_database ..." Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois@inlibro.com> Current status: Signed Off
Moving to passed QA since Mikael has signed off and freed my QA token :)
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
pushed to 18.05.x for 18.05.09
The cronjob delete_unverified_opac_registrations.pl has been deprecated in favor of cleanup_database by Bug 13049
I prefer not to apply to 17.11.x since its oldoldstable