Bug 21878 - Fix few links for opac pagination and facets (no uri filter)
Summary: Fix few links for opac pagination and facets (no uri filter)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Devinim
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 21526
Blocks: 21950
  Show dependency treegraph
 
Reported: 2018-11-23 14:19 UTC by Devinim
Modified: 2020-01-06 20:15 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21878: To fix pagination problem in OPAC (3.44 KB, patch)
2018-11-23 14:24 UTC, Devinim
Details | Diff | Splinter Review
Bug 21878: To fix pagination problem in OPAC (3.53 KB, patch)
2018-11-26 09:50 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 21878: (follow-up) Fix a few query_cgi filters in opac-search-history (5.98 KB, patch)
2018-11-26 09:51 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 21878: (follow-up) Fix a few uri filter in facets (3.76 KB, patch)
2018-11-26 09:51 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 21878: To fix pagination problem in OPAC (3.57 KB, patch)
2018-11-26 13:42 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 21878: To fix pagination problem in OPAC (3.57 KB, patch)
2018-11-26 13:44 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 21878: (follow-up) Fix a few query_cgi filters in opac-search-history (6.01 KB, patch)
2018-11-26 13:44 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 21878: (follow-up) Fix a few uri filter in facets (3.80 KB, patch)
2018-11-26 13:44 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Devinim 2018-11-23 14:19:27 UTC
After changing uri filter opac pagination problem occured.
Comment 1 Devinim 2018-11-23 14:24:48 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2018-11-26 09:14:08 UTC
QA: Looking here
Comment 3 Marcel de Rooy 2018-11-26 09:50:57 UTC Comment hidden (obsolete)
Comment 4 Marcel de Rooy 2018-11-26 09:51:03 UTC Comment hidden (obsolete)
Comment 5 Marcel de Rooy 2018-11-26 09:51:07 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall 2018-11-26 13:42:47 UTC Comment hidden (obsolete)
Comment 7 Kyle M Hall 2018-11-26 13:44:40 UTC
Created attachment 82644 [details] [review]
Bug 21878: To fix pagination problem in OPAC

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Kyle M Hall 2018-11-26 13:44:50 UTC
Created attachment 82645 [details] [review]
Bug 21878: (follow-up) Fix a few query_cgi filters in opac-search-history

We need to replace the uri filter on query_cgi to make some URLs work.

Test plan:
Check if the links on user page, search history work for biblio and auth
in current and previous release.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 9 Kyle M Hall 2018-11-26 13:44:53 UTC
Created attachment 82646 [details] [review]
Bug 21878: (follow-up) Fix a few uri filter in facets

We need to adjust a few query_cgi | uri filters here too.
Note that sort_by should be filtered by uri, not url.

Similar change on staff side.

Test plan:
Toggle Show all items/Limit available items.
Check: git grep -l "query_cgi | uri"

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Nick Clemens 2018-11-26 14:31:30 UTC
Awesome work all!

Pushed to master for 18.11
Comment 11 Lucas Gass 2018-12-13 16:15:07 UTC
depends on 13618, not backporting to 18.05