There are no bugs blocking the removal of the non-XSLT detail view in the staff client, so let's do it.
Created attachment 87664 [details] [review] Bug 21891: Remove non-XSLT detail view in the staff client This patch removes the non-XSLT markup from the bibliographic detail page in the staff client. The XSLTDetailsDisplay preference has been altered to accommodate this change. A blank value in XSLTDetailsDisplay will now be equivalent to "default." To test, apply the patch and set the value of XSLTDetailsDisplay to either blank or "default." View the detail page for a bibliographic record in the staff client. The XSLT view should be shown.
Created attachment 87677 [details] [review] Bug 21891: Remove non-XSLT detail view in the staff client This patch removes the non-XSLT markup from the bibliographic detail page in the staff client. The XSLTDetailsDisplay preference has been altered to accommodate this change. A blank value in XSLTDetailsDisplay will now be equivalent to "default." To test, apply the patch and set the value of XSLTDetailsDisplay to either blank or "default." View the detail page for a bibliographic record in the staff client. The XSLT view should be shown. Signed-off-by: Michal Denar <black23@gmail.com>
Works really well, only one request: Let's set the XSLTDetailsDisplay to default for those that have it empty now. It will advertise the change in the database update then too. Could we also remove staff results non-XSLT?
Created attachment 87757 [details] [review] Bug 21891: (follow-up) Update database to set blank values to "default" This patch adds a database update which will update any blank values of the XSLTDetailsDisplay system preference to "default." Although a blank value will still result in the default XSLT view, it's more consistent with the other XSLT preferences to use "default." To test, apply the patch and set the XSLTDetailsDisplay to a blank value. Run the database update. The value of the XSLTDetailsDisplay system preference should now be "default."
Created attachment 87758 [details] [review] Bug 21891: (follow-up) Update database to set blank values to "default" This patch adds a database update which will update any blank values of the XSLTDetailsDisplay system preference to "default." Although a blank value will still result in the default XSLT view, it's more consistent with the other XSLT preferences to use "default." To test, apply the patch and set the XSLTDetailsDisplay to a blank value. Run the database update. The value of the XSLTDetailsDisplay system preference should now be "default." Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Marking as an enhancement as it's a cleanup piece which 'might' surprise users of the stable branch. Will not be backported to 18.11.x series.