It would be nice if the order number or basket name could be included in the subject of the ACQORDER email. At the moment, the <<aqbasket.basketname>> is not replaced when sending the email.
Created attachment 111024 [details] [review] Bug 21898: Add aqbasket to available tables for AQORDER
I really wish we'd bite the bullet and work through all notices converting them to TT and then deprecate the old syntax.. It's really challenging to maintain both and features are not carrying across between the two.
Created attachment 111025 [details] [review] Bug 21898: Add aqbasket to available tables for AQORDER This patch should allow <<aqbasket.$field>> replacements to work in both email subject and email content fields for notices. Test plan 1/ Add <<aqbasket.basketname>> into the AQORDER notice (In the subject line and content box) 2/ Trigger said notice to send (before applying the patch) 3/ Note that the replacements have not taken place.. <<aqbasket.basketname>> is present as is. 4/ Apply patch 5/ Trigger the notice again 6/ Note that the replacements are now made. 7/ Signoff
Created attachment 112027 [details] [review] Bug 21898: Add aqbasket to available tables for AQORDER This patch should allow <<aqbasket.$field>> replacements to work in both email subject and email content fields for notices. Test plan 1/ Add <<aqbasket.basketname>> into the AQORDER notice (In the subject line and content box) 2/ Trigger said notice to send (before applying the patch) 3/ Note that the replacements have not taken place.. <<aqbasket.basketname>> is present as is. 4/ Apply patch 5/ Trigger the notice again 6/ Note that the replacements are now made. 7/ Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Patch works fine ! Note I didn't have problem on master on step 3 : basketname was correctly displayed on the content of email.
Created attachment 112039 [details] [review] Bug 21898: Add aqbasket to available tables for AQORDER This patch should allow <<aqbasket.$field>> replacements to work in both email subject and email content fields for notices. Test plan 1/ Add <<aqbasket.basketname>> into the AQORDER notice (In the subject line and content box) 2/ Trigger said notice to send (before applying the patch) 3/ Note that the replacements have not taken place.. <<aqbasket.basketname>> is present as is. 4/ Apply patch 5/ Trigger the notice again 6/ Note that the replacements are now made. 7/ Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Bug 26745 would go really nicely with this one ;)
Created attachment 112979 [details] [review] Bug 21898: Add aqbasket to available tables for ACQORDER This patch should allow <<aqbasket.$field>> replacements to work in both email subject and email content fields for notices. Test plan 1/ Add <<aqbasket.basketname>> into the ACQORDER notice (In the subject line and content box) 2/ Trigger said notice to send (before applying the patch) 3/ Note that the replacements have not taken place.. <<aqbasket.basketname>> is present as is. 4/ Apply patch 5/ Trigger the notice again 6/ Note that the replacements are now made. 7/ Signoff Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> JD amended patch: fix alignment in hashref, edit commit message to fix letter code "AQORDER" vs "ACQORDER"
Created attachment 112980 [details] [review] Bug 21898: Add basket for TT syntax Without this patch the basket's info won't be available for the TT syntax. With this patch you can now use [% basket.basketname %]
Pushed to master for 20.11, thanks to everybody involved!
There is a failing test, can you have a look, Martin? # Failed test 'SendAlerts - claimissue' # at t/db_dependent/Letters.t line 642. C4::Letters::_substitute_tables(): DBI Exception: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed [for Statement "SELECT * FROM aqbasket WHERE basketno = ?" with ParamValues: 0=26] at /kohadevbox/koha/C4/Letters.pm line 679
(In reply to Jonathan Druart from comment #11) > There is a failing test, can you have a look, Martin? > > # Failed test 'SendAlerts - claimissue' > # at t/db_dependent/Letters.t line 642. > C4::Letters::_substitute_tables(): DBI Exception: DBD::mysql::st execute > failed: called with 2 bind variables when 1 are needed [for Statement > "SELECT * FROM aqbasket WHERE basketno = ?" with ParamValues: 0=26] at > /kohadevbox/koha/C4/Letters.pm line 679 Fixed on bug 26935.
enhancement will not be backported to 20.05.x