Bug 21933 - Renew or chek in selected items
Summary: Renew or chek in selected items
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 18.11
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-03 09:11 UTC by sergeinik
Modified: 2020-06-04 20:32 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Russian interface (25.76 KB, image/png)
2018-12-03 09:11 UTC, sergeinik
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sergeinik 2018-12-03 09:11:19 UTC
Created attachment 82823 [details]
Russian interface

After the last update, when viewing the user's literature list from the administrator interface, the output of information hangs if the biblographic records are old enough. For new entries, everything is working fine. If the user has old and new entries in the list, the interface also hangs.
Comment 1 Katrin Fischer 2018-12-03 21:27:28 UTC
Have you cleared your browser cache after the update?

As this is done with JavaScript - is there a JavaScript error in the browser's developer tools you could share?
Comment 2 sergeinik 2018-12-04 06:19:13 UTC
1. This is not related to the browser cache, since the problem recurs in any browser and on any computer.

2. JavaScript errors:

checkouts_18.1100000.js:310 Uncaught TypeError: Cannot read property 'escapeHtml' of null
    at mDataProp (checkouts_18.1100000.js:310)
    at jquery.dataTables.min_18.1100000.js:18
    at Object.b.fnGetData (jquery.dataTables.min_18.1100000.js:12)
    at B (jquery.dataTables.min_18.1100000.js:16)
    at Ja (jquery.dataTables.min_18.1100000.js:24)
    at N (jquery.dataTables.min_18.1100000.js:16)
    at jquery.dataTables.min_18.1100000.js:48
    at i (jquery.dataTables.min_18.1100000.js:35)
    at Object.success (checkouts_18.1100000.js:514)
    at i (jquery-2.2.3.min_18.1100000.js:2)
mDataProp @ checkouts_18.1100000.js:310
(anonymous) @ jquery.dataTables.min_18.1100000.js:18
b.fnGetData @ jquery.dataTables.min_18.1100000.js:12
B @ jquery.dataTables.min_18.1100000.js:16
Ja @ jquery.dataTables.min_18.1100000.js:24
N @ jquery.dataTables.min_18.1100000.js:16
(anonymous) @ jquery.dataTables.min_18.1100000.js:48
i @ jquery.dataTables.min_18.1100000.js:35
(anonymous) @ checkouts_18.1100000.js:514
i @ jquery-2.2.3.min_18.1100000.js:2
fireWith @ jquery-2.2.3.min_18.1100000.js:2
z @ jquery-2.2.3.min_18.1100000.js:4
(anonymous) @ jquery-2.2.3.min_18.1100000.js:4
load (async)
send @ jquery-2.2.3.min_18.1100000.js:4
ajax @ jquery-2.2.3.min_18.1100000.js:4
n.(anonymous function) @ jquery-2.2.3.min_18.1100000.js:4
getJSON @ jquery-2.2.3.min_18.1100000.js:4
fnServerData @ checkouts_18.1100000.js:513
ra @ jquery.dataTables.min_18.1100000.js:36
ia @ jquery.dataTables.min_18.1100000.js:48
(anonymous) @ jquery.dataTables.min_18.1100000.js:95
each @ jquery-2.2.3.min_18.1100000.js:2
each @ jquery-2.2.3.min_18.1100000.js:2
m @ jquery.dataTables.min_18.1100000.js:85
KohaTable @ moremember.pl?borrowernumber=30:1324
LoadIssuesTable @ checkouts_18.1100000.js:184
(anonymous) @ checkouts_18.1100000.js:166
dispatch @ jquery-2.2.3.min_18.1100000.js:3
r.handle @ jquery-2.2.3.min_18.1100000.js:3
Comment 3 Katrin Fischer 2018-12-04 08:11:19 UTC
Sometimes things break from translation - does the problem appear with the English templates as well? What version did you update to?

I can't test right now, but this might help to narrow it down a bit more.
Comment 4 sergeinik 2018-12-04 08:24:14 UTC
Both with English and with Russian interfaces the same problem. We have a Russian version.
Comment 5 Katrin Fischer 2018-12-04 14:49:40 UTC
I meant the Koha version - you listed it above as master, which is unlikely. The exact version is listed on the first tab of the About page.
Comment 6 sergeinik 2018-12-04 14:59:14 UTC
Sorry. 18.11.00.000
Comment 7 Owen Leonard 2018-12-04 15:28:37 UTC
(In reply to sergeinik from comment #2)

> checkouts_18.1100000.js:310

Line 310 of checkouts.js is where an item's home library is displayed, so it sounds like you have one or more items with a null value in items.homebranch. 

I think the script skips error-checking for this value because it is expected that all items will have a value in items.homebranch -- Koha requires it for circulation.

I'm marking this bug "invalid" because this is really a data problem instead of a bug, but it would be worthwhile for us to include error-checking even for values which are mandatory.
Comment 8 sergeinik 2018-12-04 16:07:53 UTC
Thank you so much, I saw it.
Comment 9 dguidry 2019-06-27 15:22:42 UTC
We just ran into this same problem after upgrading Koha (US English) from 18.05 to 19.05. Our Koha installation goes back a few years (3.x), but we haven't had a problem with this until this recent upgrade. It sounds like something must have changed in 18.11 and is still affecting 19.05. It would be lovely if this issue could be accounted for in the affected javascript code or if it could be checked during the upgrade process if this new code will cause such a break in functionality.

Meanwhile, this bug has at least pointed me into an actionable direction. I've now found that some accounts are affected and others aren't, likely due to the fact that some checkouts must have the homebranch field missing. I'll try and locate these items in the database and see how many are affected and then attempt manual resolution there.