Bug 21934 - Allow user to specify name for 'Shibboleth'
Summary: Allow user to specify name for 'Shibboleth'
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-03 14:34 UTC by Nick Clemens
Modified: 2021-04-16 06:59 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21934 - Allow user to specify name for 'Shibboleth' (8.44 KB, patch)
2018-12-03 14:51 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 21934: Database update (1.19 KB, patch)
2018-12-11 19:23 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 21934 - Allow user to specify name for 'Shibboleth' (8.46 KB, patch)
2018-12-12 13:46 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2018-12-03 14:34:32 UTC
Many sites using SAML (Shibboleth) don't refer to their login as a 'Shibboleth login' 

We shoudl make it easy for the user to specify what they call the service
Comment 1 Nick Clemens 2018-12-03 14:51:03 UTC
Created attachment 82825 [details] [review]
Bug 21934  - Allow user to specify name for 'Shibboleth'

To test:
1 - Add a shibboleth config to your koha-conf.xml file (it does not need
        to be valid)
      <useshibboleth>1</useshibboleth>
        <shibboleth>
          <matchpoint>userid</matchpoint>
          <mapping>
            <userid is="uid"></userid>
          </mapping>
        </shibboleth>
2 - Note on staff and user auth pages the message says "Shibboleth
account"
3 - Apply patch, update database
4 - Note login text has not changed
5 - Define a name in 'shibbolethName'
6 - Note it is reflected on all auth pages
Comment 2 Katrin Fischer 2018-12-03 20:33:28 UTC
Patches like these are problematic, because they make the text mono-lingual and harder to translate as we will be missing context.
Comment 3 Nick Clemens 2018-12-11 19:23:57 UTC
Created attachment 83059 [details] [review]
Bug 21934: Database update
Comment 4 Nick Clemens 2018-12-11 19:25:59 UTC
(In reply to Katrin Fischer from comment #2)
> Patches like these are problematic, because they make the text mono-lingual
> and harder to translate as we will be missing context.

Won't the string showup in the PO as a string with a %s? So that the translation can be written in a sensible way, and the user should be aware of changing the text to fit the context?

The other side is that we use a lot of jquery to change this and it is easy to miss - I suppose we could simply add a span whenever the word 'Shibboleth' is used if that is preferable?
Comment 5 Katrin Fischer 2018-12-11 20:57:09 UTC
Yeah, but translating '%s login failed' is harder then translating "Shibboleth login failed".

It also means that you can't deal with those terms using .po files anymore, some might maintain their own .po files to deal with things like that. It forces people to use jQuery in order to have them multi-lingual. It makes it easy for everyone using only one language in their OPAC, but everyone who offers more than one, will still have to use jQuery.

Just explaining where I am coming from. In the case of Shibboleth which is already an odd term... I won't block this. Just thinking this should not turn into a standard way of dealing with terms people want to change.
Comment 6 Katrin Fischer 2018-12-11 20:57:24 UTC
... also: missing filters!
Comment 7 Nick Clemens 2018-12-12 13:46:36 UTC
Created attachment 83116 [details] [review]
Bug 21934 - Allow user to specify name for 'Shibboleth'

To test:
1 - Add a shibboleth config to your koha-conf.xml file (it does not need
        to be valid)
      <useshibboleth>1</useshibboleth>
        <shibboleth>
          <matchpoint>userid</matchpoint>
          <mapping>
            <userid is="uid"></userid>
          </mapping>
        </shibboleth>
2 - Note on staff and user auth pages the message says "Shibboleth
account"
3 - Apply patch, update database
4 - Note login text has not changed
5 - Define a name in 'shibbolethName'
6 - Note it is reflected on all auth pages
Comment 8 Chris Cormack 2018-12-12 21:13:57 UTC
I agree with Katrin, this makes koha less translatable, it will directly impact a few of our customers and also lots of other Koha users.

Can we come up with a better way of doing this (and also think of how we can move any of the stuff we currently have in sys prefs into a more translatable format)