There are some minor markup issues with the holds template in the staff client, including needing a Bootstrap grid upgrade.
Created attachment 82847 [details] [review] Bug 21943: Clean up holds template This patch makes a few markup corrections to the holds template in the staff client: Replace some YUI markup with Bootstrap; Replace invalid "alt" attributes with "title." To test, apply the patch and test the process of placing a hold, both single and multiple holds. At each step of the process the page should look correct and adjust well at various browser widths.
Created attachment 86305 [details] Screenshot of responsive view Hi, Sorry the responsive view doesn't look quite right. Have a look? Cheers, Liz
Created attachment 86454 [details] [review] Bug 21943: (follow-up) Fix float error with sidebar menu This patch makes a minor change to the staff client CSS to fix a float clearing problem when the <main> element contains only a floated element like <fieldset>. It is a global change, but shouldn't cause unwanted effects because a non-clearing <main> isn't used in any float-dependent layouts. To test, apply the patch and regenerate the staff client CSS. View the place hold screen and confirm that the sidebar menu looks correct at narrower browser widths.
Created attachment 87533 [details] [review] Bug 21943: Clean up holds template This patch makes a few markup corrections to the holds template in the staff client: Replace some YUI markup with Bootstrap; Replace invalid "alt" attributes with "title." To test, apply the patch and test the process of placing a hold, both single and multiple holds. At each step of the process the page should look correct and adjust well at various browser widths. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 87534 [details] [review] Bug 21943: (follow-up) Fix float error with sidebar menu This patch makes a minor change to the staff client CSS to fix a float clearing problem when the <main> element contains only a floated element like <fieldset>. It is a global change, but shouldn't cause unwanted effects because a non-clearing <main> isn't used in any float-dependent layouts. To test, apply the patch and regenerate the staff client CSS. View the place hold screen and confirm that the sidebar menu looks correct at narrower browser widths. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 87554 [details] [review] Bug 21943: Clean up holds template This patch makes a few markup corrections to the holds template in the staff client: Replace some YUI markup with Bootstrap; Replace invalid "alt" attributes with "title." To test, apply the patch and test the process of placing a hold, both single and multiple holds. At each step of the process the page should look correct and adjust well at various browser widths. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 87555 [details] [review] Bug 21943: (follow-up) Fix float error with sidebar menu This patch makes a minor change to the staff client CSS to fix a float clearing problem when the <main> element contains only a floated element like <fieldset>. It is a global change, but shouldn't cause unwanted effects because a non-clearing <main> isn't used in any float-dependent layouts. To test, apply the patch and regenerate the staff client CSS. View the place hold screen and confirm that the sidebar menu looks correct at narrower browser widths. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.