There are some minor markup issues with the stock rotation template under tools, including needing a Bootstrap grid upgrade.
Created attachment 82849 [details] [review] Bug 21945: Clean up stock rotation template This patch makes some minor markup upgrades to the stock rotation template: Replace some YUI markup with Bootstrap; Add some missing <tr> tags; Remove invalid "type" attribute from <script> tag. To test, apply the patch and go to Tools -> Stock rotation. Confirm that the page looks correct and adjusts well at various browser widths. Test with various views: New rota, edit rota, manage stages, manage items.
Created attachment 84220 [details] [review] Bug 21945: Clean up stock rotation template This patch makes some minor markup upgrades to the stock rotation template: Replace some YUI markup with Bootstrap; Add some missing <tr> tags; Remove invalid "type" attribute from <script> tag. To test, apply the patch and go to Tools -> Stock rotation. Confirm that the page looks correct and adjusts well at various browser widths. Test with various views: New rota, edit rota, manage stages, manage items. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com>
Created attachment 84235 [details] [review] Bug 21945: Clean up stock rotation template This patch makes some minor markup upgrades to the stock rotation template: Replace some YUI markup with Bootstrap; Add some missing <tr> tags; Remove invalid "type" attribute from <script> tag. To test, apply the patch and go to Tools -> Stock rotation. Confirm that the page looks correct and adjusts well at various browser widths. Test with various views: New rota, edit rota, manage stages, manage items. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Thanks for tidying this Owen :)