Bug 13618 added a | html to line 717 of opac-details.tt but this generates strange <br> output in the 'Title notes' tab: this<br /> <hr><br /> <br /> is<br /> <hr><br /> <br /> a<br /> <hr><br /> <br /> test from blank lines entered into a 500$a field --- BEGIN --- this <hr> is <hr> a <hr> test --- END --- While HTML (<hr>) should not be in a note, this is used as sample data to also check the blank line to <br>-ish tags, as shown above.
Created attachment 82850 [details] [review] Bug 21947: Swap the filter order TEST PLAN ---------- 1) start your kohadevbox 2) cd kohaclone 3) git checkout -b bug_21947 origin/master 4) git bz apply 21947 5) reset_all 6) log in to staff client and add a 500$a with lots of blank lines between strings with some HTML. 7) look at the opac record Title notes tab. -- does it have <br>-mess? Should not. 8) repeat steps 5-7 on master, and you'll see a <br>-mess. 9) run qa test tools
Now if you have a 500$a of: --- BEGIN --- this is a test --- END --- you should see --- BEGIN --- this is a test --- END --- at the start of the Title notes.
What about other occurrences of `git grep "FILTER html_line_break | html"`?
Created attachment 82857 [details] [review] Bug 21947: Address other misordered FILTER lines As per comment #3, this patch changes the order for all the filters found with the recommended git grep.
(In reply to Jonathan Druart from comment #3) > What about other occurrences of `git grep "FILTER html_line_break | html"`? I've attached a patch which should address them all. However, given that I never knew how to trigger them. A test plan is left as an exercise for the reader.
(In reply to M. Tompsett from comment #0) > While HTML (<hr>) should not be in a note, ... It should be noted that David Cook corrected this poor assumption by pointing out 887: https://www.loc.gov/marc/bibliographic/bd887.html But this patch doesn't touch anything 887-wise, as far as I know. However, it would be a good thing to check for in another bug.
Created attachment 82861 [details] [review] Bug 21947: Swap the filter order TEST PLAN ---------- 1) start your kohadevbox 2) cd kohaclone 3) git checkout -b bug_21947 origin/master 4) git bz apply 21947 5) reset_all 6) log in to staff client and add a 500$a with lots of blank lines between strings with some HTML. 7) look at the opac record Title notes tab. -- does it have <br>-mess? Should not. 8) repeat steps 5-7 on master, and you'll see a <br>-mess. 9) run qa test tools Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 82862 [details] [review] Bug 21947: Address other misordered FILTER lines As per comment #3, this patch changes the order for all the filters found with the recommended git grep. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 82921 [details] [review] Bug 21947: Swap the filter order TEST PLAN ---------- 1) start your kohadevbox 2) cd kohaclone 3) git checkout -b bug_21947 origin/master 4) git bz apply 21947 5) reset_all 6) log in to staff client and add a 500$a with lots of blank lines between strings with some HTML. 7) look at the opac record Title notes tab. -- does it have <br>-mess? Should not. 8) repeat steps 5-7 on master, and you'll see a <br>-mess. 9) run qa test tools Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 82922 [details] [review] Bug 21947: Address other misordered FILTER lines As per comment #3, this patch changes the order for all the filters found with the recommended git grep. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.01
depends on 13618, not backporting to 18.05