Unfortunately the permission got added to the DB as manage_didyouean when it should be manage_didyoumean...
Created attachment 82903 [details] [review] Bug 21961: Fix typo in manage_didyoumean permission The typo in the installer files will cause problems on new installations as the code for the permission is wrong. This means that on new installations the Did you mean? section on the administration page won't show up. In order to fix this, we need to correct the code in permissions, but also the permissions for users who this permission has been given to. To test: - Start without the patch - Use a new installation with the permission typo - Log in as superlibrarian - Verify that the "did you mean?" configuration page is not visible - Create another staff user with permission to access staff and manage_didyoumean checked - Verify configuration page remains invisible - Apply patch and run database update - Check both users again, the config page should now sohw
*** Bug 21960 has been marked as a duplicate of this bug. ***
Created attachment 82904 [details] [review] Bug 21961: Fix typo in manage_didyoumean permission The typo in the installer files will cause problems on new installations as the code for the permission is wrong. This means that on new installations the Did you mean? section on the administration page won't show up. In order to fix this, we need to correct the code in permissions, but also the permissions for users who this permission has been given to. To test: - Start without the patch - Use a new installation with the permission typo - Log in as superlibrarian - Verify that the "did you mean?" configuration page is not visible - Create another staff user with permission to access staff and manage_didyoumean checked - Verify configuration page remains invisible - Apply patch and run database update - Check both users again, the config page should now sohw Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 82981 [details] [review] Bug 21961: Fix typo in manage_didyoumean permission The typo in the installer files will cause problems on new installations as the code for the permission is wrong. This means that on new installations the Did you mean? section on the administration page won't show up. In order to fix this, we need to correct the code in permissions, but also the permissions for users who this permission has been given to. To test: - Start without the patch - Use a new installation with the permission typo - Log in as superlibrarian - Verify that the "did you mean?" configuration page is not visible - Create another staff user with permission to access staff and manage_didyoumean checked - Verify configuration page remains invisible - Apply patch and run database update - Check both users again, the config page should now sohw Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
> In order to fix this, we need to correct the code in permissions, but also the > permissions for users who this permission has been given to. Note that it shouldn't be necessary to manually update user_permissions (thanks to the 'ON UPDATE CASCADE' on the FK constraint, mysql takes care of it), but it is harmless, so we can keep both queries.
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.01
missing 14391 dependency not backporting to 18.05