Bug 21581 allowed passing custom indexes through the authorities search, however, we failed to catch the case where 'attr1 = all' was converted to 'Any'
Created attachment 82905 [details] [review] Bug 21962: Unit tests
Created attachment 82906 [details] [review] Bug 21962: Fix authority search using 'all' To test: 1 - Set search engine to Zebra 2 - Have some authorities and indexes up to date 3 - Search authorities with option 'search entire record' 4 - No results 5 - Apply patch 6 - Run unit tests, they pass! 7 - Repeat search 8 - Results!
Created attachment 82999 [details] [review] Bug 21962: Unit tests Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Created attachment 83000 [details] [review] Bug 21962: Fix authority search using 'all' To test: 1 - Set search engine to Zebra 2 - Have some authorities and indexes up to date 3 - Search authorities with option 'search entire record' 4 - No results 5 - Apply patch 6 - Run unit tests, they pass! 7 - Repeat search 8 - Results! Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Created attachment 83031 [details] [review] Bug 21962: Unit tests Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 83032 [details] [review] Bug 21962: Fix authority search using 'all' To test: 1 - Set search engine to Zebra 2 - Have some authorities and indexes up to date 3 - Search authorities with option 'search entire record' 4 - No results 5 - Apply patch 6 - Run unit tests, they pass! 7 - Repeat search 8 - Results! Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.01
Pushed to 18.05.x for 18.05.07
*** Bug 22040 has been marked as a duplicate of this bug. ***
Pushed to 17.11.x for 17.11.14 Note that backport to 18.05.x created a followup : Bug 21962: (RMaint follow-up) Fixed bad rebase.