Created attachment 82944 [details] [review]
Bug 21971: gimme_an_item

gimme ?
See comment3 and 4 on bug 21798

(In reply to Marcel de Rooy from comment #2)
> gimme ?
> See comment3 and 4 on bug 21798

I do not want to get stuck because of wording, substitution can be done easily if something else is suggested (which has not been done so far).

(In reply to Jonathan Druart from comment #3)
> (In reply to Marcel de Rooy from comment #2)
> > gimme ?
> > See comment3 and 4 on bug 21798
> 
> I do not want to get stuck because of wording, substitution can be done
> easily if something else is suggested (which has not been done so far).

Hmm. But if you are not the writer, different rules apply, heh ?

Should not be very hard to suggest something else ;)
What about create_item, create_test_item; build_item ?

Created attachment 83139 [details] [review]
Bug 21971: TestBuilder::build_sample_item

fatal: sha1 information is lacking or useless (t/db_dependent/Circulation.t).

I would expect to use builder inside build_sample_item and no longer see C4::Items::AddItem.
No +1 from me ;)

(In reply to Marcel de Rooy from comment #8)
> I would expect to use builder inside build_sample_item and no longer see
> C4::Items::AddItem.
> No +1 from me ;)

It does not work :) AddItem does much more than just creating a new row in the items table.