Bug 21526 applies the "url" filter on the CAS login link despite it being escaped already in C4/Auth_with_cas.pm, resulting in a double escape and a non-functioning login via CAS.
Created attachment 82978 [details] [review] Bug 21973: Do not url escape casServerUrl It is already escaped correctly in C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape Note that shibbolethLoginUrl is not and must be url escaped in template ("be consistent, they said")
Created attachment 83022 [details] [review] Bug 21973: Do not url escape casServerUrl It is already escaped correctly in C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape Note that shibbolethLoginUrl is not and must be url escaped in template ("be consistent, they said")
Created attachment 83169 [details] [review] Bug 21973: Do not url escape casServerUrl It is already escaped correctly in C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape Note that shibbolethLoginUrl is not and must be url escaped in template ("be consistent, they said") Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 83178 [details] [review] Bug 21973: Do not url escape casServerUrl It is already escaped correctly in C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape Note that shibbolethLoginUrl is not and must be url escaped in template ("be consistent, they said") Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Be nice to fix this in with Auth_with_cas or Auth_with_shibboleth to be consistent.. but that work shouldn't hold this patch up.
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.01
Not needed for 18.05.x