<div class="dialog error"> will display a div without background color, the correct class is "dialog alert". https://wiki.koha-community.org/wiki/Interface_patterns#Error_messages
Created attachment 83131 [details] [review] Bug 21990: Replace dialog .error with .alert <div class="dialog error"> will display a div without background color, the correct class is "dialog alert". https://wiki.koha-community.org/wiki/Interface_patterns#Error_messages Test plan: Hit /cgi-bin/koha/acqui/parcel.pl Notice the background color change with and without this patch
Created attachment 83239 [details] [review] Bug 21990: Replace dialog .error with .alert <div class="dialog error"> will display a div without background color, the correct class is "dialog alert". https://wiki.koha-community.org/wiki/Interface_patterns#Error_messages Test plan: Hit /cgi-bin/koha/acqui/parcel.pl Notice the background color change with and without this patch Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Created attachment 83565 [details] [review] Bug 21990: Replace dialog .error with .alert <div class="dialog error"> will display a div without background color, the correct class is "dialog alert". https://wiki.koha-community.org/wiki/Interface_patterns#Error_messages Test plan: Hit /cgi-bin/koha/acqui/parcel.pl Notice the background color change with and without this patch Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Cosmetic fix, Pushed to 18.11.x for 18.11.02
Pushed to 18.05.x for 18.05.08
Pushed to 17.11.x for 17.11.14