Bug 22000 - Remove extraneous parameters from API route spec
Summary: Remove extraneous parameters from API route spec
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-14 14:47 UTC by Andrew Isherwood
Modified: 2023-01-13 11:08 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 22000: Add unit test (1.41 KB, patch)
2022-02-17 22:12 UTC, Lari Taskula
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Isherwood 2018-12-14 14:47:05 UTC
As noted in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460#c9 the "get" route definition makes reference to a bunch of query parameters that have no handling in the endpoint controller. We should remove these.
Comment 1 Lari Taskula 2022-02-17 22:12:18 UTC
I don't think we should remove the parameters, but rather make them work. Someone may find these parameters useful.
Comment 2 Lari Taskula 2022-02-17 22:12:53 UTC
Created attachment 130775 [details] [review]
Bug 22000: Add unit test

To test:
1. prove t/db_dependent/api/v1/illrequests.t
2. Observe test failure
t/db_dependent/api/v1/illrequests.t ..
    #   Failed test 'exact match for JSON Pointer ""'
    #   at t/db_dependent/api/v1/illrequests.t line 163.
...
Comment 3 Katrin Fischer 2023-01-13 10:37:10 UTC
Not sure about this one and I believe the API has seen some changes since this was filed. Could one of our API experts check?