When adding the new splitting rules for classification source with bug 15836, we missed updating the translated installers. I will provide a patch for the SQL file. We will need another with a database update as new installations might have been created with missing set up.
Created attachment 83374 [details] [review] Bug 22024 - Update translated web installer files with new class splitting rules When adding the new splitting rules for classification sources with bug 15836, we missed updating the translated installers. This has the danger of data missing for new installations already set up with 18.11. This patch corrects the installer files. To test: - Verify the class_sources.sql installs correctly for all languages
Created attachment 83375 [details] [review] Bug 22024: Correct new installations with missing data For a new installation the data in the class_* will be missing as class_sources.sql couldn't be executed. It will fail with: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`class_sources`, CONSTRAINT `class_source_ibfk_2` FOREIGN KEY (`class_split_rule`) REFERENCES `class_split_rules` (`class_split_rule`)) at /usr/share/perl5/DBIx/RunSQL.pm line 273. As this might have been missed and the web installer can still be completed, this patch checks for the tables being empty and adds the default data if they are. To test: - Without the patch - Run the de-DE or another translated installer - Verify the error is shown - Complete the installer - Verify class_sources table is empty - Apply patches - Run the database update - Verify data classification sources, filing rules, and slitting rules are now complete
Created attachment 83396 [details] [review] Bug 22024: Update translated web installer files with new class splitting rules When adding the new splitting rules for classification sources with bug 15836, we missed updating the translated installers. This has the danger of data missing for new installations already set up with 18.11. This patch corrects the installer files. To test: - Verify the class_sources.sql installs correctly for all languages Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 83397 [details] [review] Bug 22024: Correct new installations with missing data For a new installation the data in the class_* will be missing as class_sources.sql couldn't be executed. It will fail with: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`class_sources`, CONSTRAINT `class_source_ibfk_2` FOREIGN KEY (`class_split_rule`) REFERENCES `class_split_rules` (`class_split_rule`)) at /usr/share/perl5/DBIx/RunSQL.pm line 273. As this might have been missed and the web installer can still be completed, this patch checks for the tables being empty and adds the default data if they are. To test: - Without the patch - Run the de-DE or another translated installer - Verify the error is shown - Complete the installer - Verify class_sources table is empty - Apply patches - Run the database update - Verify data classification sources, filing rules, and slitting rules are now complete Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 83398 [details] [review] Bug 22024: Fix number of fields in uk-UA ERROR 1136 (21S01) at line 23: Column count doesn't match value count at row 22 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Skipping QA.
Thx for catching the missing ones and the sign-off!
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.01
15836 dependency is not in 18.05, wont backport