This script is really hard to read with lots of weird indent symbols at the start of lines... could use a tidy up
Created attachment 83932 [details] [review] Bug 22036: Indented code where '^I' was written rather than an indent. Code was previously written with '^I' where an indent was supposed to be. I deleted all '^I's and replaced them with indents. To find this change: Look at the tags/review.pl file and confirm indentation is correct
Created attachment 83968 [details] [review] Bug 22036: Indented code where '^I' was written rather than an indent. Code was previously written with '^I' where an indent was supposed to be. I deleted all '^I's and replaced them with indents. To find this change: Look at the tags/review.pl file and confirm indentation is correct Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 83997 [details] [review] Bug 22036: Indented code where '^I' was written rather than an indent. Code was previously written with '^I' where an indent was supposed to be. I deleted all '^I's and replaced them with indents. To find this change: Look at the tags/review.pl file and confirm indentation is correct Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Good job!
Awesome work Jasmine! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
Pushed to 18.05.x for 18.05.09
Not a real bug, I prefer not to push to 17.11.x.