To test: 1) Enable OnSiteCheckouts system preference 2) Checkout an item checking the onsite checkout checkbos in more options 3) Go to circulation > pending on-site checkouts 4) Verify the checkout shows 5) Go to circulation > renew 6) Try to renew the on-site checkout using the barcode 7) Verify display: onsite_checkout Continue without renewing onsite_checkout reads like a code and should be replaced with a proper message.
Created attachment 83933 [details] [review] Bug 22054: Updated the error message for attempting to renew an onsite checkout To test: 1) Enable OnSiteCheckouts system preference 2) Checkout an item checking the onsite checkout checkbos in more options 3) Go to circulation > pending on-site checkouts 4) Verify the checkout shows 5) Go to circulation > renew 6) Try to renew the on-site checkout using the barcode 7) Verify display: onsite_checkout Continue without renewing 8) apply the patch and reload page with error message 9) verify display: Item cannot be renewed because it's an onsite checkout
Switching to "Needs Signoff".
Created attachment 83960 [details] [review] Bug 22054: Updated the error message for attempting to renew an onsite checkout To test: 1) Enable OnSiteCheckouts system preference 2) Checkout an item checking the onsite checkout checkbos in more options 3) Go to circulation > pending on-site checkouts 4) Verify the checkout shows 5) Go to circulation > renew 6) Try to renew the on-site checkout using the barcode 7) Verify display: onsite_checkout Continue without renewing 8) apply the patch and reload page with error message 9) verify display: Item cannot be renewed because it's an onsite checkout Signed-off-by: David Nind <david@davidnind.com>
Created attachment 83999 [details] [review] Bug 22054: Updated the error message for attempting to renew an onsite checkout To test: 1) Enable OnSiteCheckouts system preference 2) Checkout an item checking the onsite checkout checkbos in more options 3) Go to circulation > pending on-site checkouts 4) Verify the checkout shows 5) Go to circulation > renew 6) Try to renew the on-site checkout using the barcode 7) Verify display: onsite_checkout Continue without renewing 8) apply the patch and reload page with error message 9) verify display: Item cannot be renewed because it's an onsite checkout Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Good catch!
Awesome work Helene! Congratulations on your first patch! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
Pushed to 18.05.x for 18.05.09
Pushed to 17.11.x for 17.11.15