Created attachment 83699 [details] [review] Bug 22066: Record library_id for manual credits On creating manual credits, the (newly introduced) branchcode should be set now. This trivial patch makes it work. To test: - Create a manual credit for a known patron - Using MySQL check the result: $ sudo mysql > SELECT * FROM accountlines WHERE borrowernumber=<known_id>; => FAIL: The created accountline row has NULL for the branchcode - Apply this patch - Create a manual credit for the patron - Run: > SELECT * FROM accountlines WHERE borrowernumber=<known_id>; => SUCCESS: branchcode is set correctly -Sign off :-D
Created attachment 83742 [details] [review] Bug 22066: Record library_id for manual credits On creating manual credits, the (newly introduced) branchcode should be set now. This trivial patch makes it work. To test: - Create a manual credit for a known patron - Using MySQL check the result: $ sudo mysql > SELECT * FROM accountlines WHERE borrowernumber=<known_id>; => FAIL: The created accountline row has NULL for the branchcode - Apply this patch - Create a manual credit for the patron - Run: > SELECT * FROM accountlines WHERE borrowernumber=<known_id>; => SUCCESS: branchcode is set correctly -Sign off :-D Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 83744 [details] [review] Bug 22066: Record library_id for manual credits On creating manual credits, the (newly introduced) branchcode should be set now. This trivial patch makes it work. To test: - Create a manual credit for a known patron - Using MySQL check the result: $ sudo mysql > SELECT * FROM accountlines WHERE borrowernumber=<known_id>; => FAIL: The created accountline row has NULL for the branchcode - Apply this patch - Create a manual credit for the patron - Run: > SELECT * FROM accountlines WHERE borrowernumber=<known_id>; => SUCCESS: branchcode is set correctly -Sign off :-D Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
Merge conflict with 18.05.x. Please rebase to 18.05.x if needed.
The dependency is not in 18.05, so it is safe to skip this one!